Review main Merged Breaking

6618[BUGFIX][!!!] Slider wizard misuses "max" property

Francois Suter CR +2 V +2 Easy +8 −2 updated 06/03/13, 20:49

Commit message

TYPO3 4.6 introduced a slider wizard for select-type and
input-type fields. For input-type fields it is possible
to define a minimum and maximum value for the slider.
Unfortunately the wizard misuses the "max" TCA property
for the maximum value, which is normally used for the
"maxlength" attribute of the input field.

The slider wizard should instead rely on the "range" property,
which already exists and serves exactly the purpose of defining
a minimum and maximum value for the field.

Review

  • Code review CR +2
    • Francois Suter +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Kay Strobach +1
  • Verified V +2
    • Francois Suter +2
    • Georg Ringer +1
    • Kay Strobach +1

Files 1

Review log 6

  1. Francois Suter commented on patch set 1 V 0 11/11/11, 14:42

    by team member; Looks good to me, approved
  2. Stefan Neufeind commented on patch set 1 11/11/11, 14:42

    Looks good to me, but someone else must approve
  3. Georg Ringer commented on patch set 1 11/11/11, 14:42

    Verified; Looks good to me, but someone else must approve
  4. Kay Strobach commented on patch set 1 11/11/11, 14:42

    Verified; Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 11/11/11, 14:42

  6. Francois Suter merged patch set 1 11/11/11, 14:42