Review main Merged

66182[TASK] Drop a series of unused code occurences

Christian Kuhn CR +2 V +2 Easy +7 −38 updated 10/28/20, 12:00

Commit message

A couple of not needed assignments throughout the
core and a 'too many arguments' fix.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 18

Review log 1216

  1. Christian Kuhn uploaded patch set 1 10/19/20, 21:51

  2. TYPO3com voted on patch set 1 V -1 10/19/20, 21:59 Completed build in 43s on Mon, 19 Oct, 09:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6676

  3. Christian Kuhn uploaded patch set 2 10/19/20, 22:17

  4. TYPO3com voted on patch set 2 V +1 10/19/20, 22:29 Completed build in 12m 15s on Mon, 19 Oct, 10:29 PM Test Summary: 73839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6678

  5. Georg Ringer voted on patch set 2 CR +1 10/20/20, 06:10

  6. Daniel Goerz commented on patch set 2 10/20/20, 08:39

    ElementBrowserPageTreeView.php:170

    Comment still says there's an anchor point
  7. Christian Kuhn uploaded patch set 3 10/20/20, 10:12

  8. Christian Kuhn commented on patch set 3 10/20/20, 10:12

    ElementBrowserPageTreeView.php:170 Reply

    Done
  9. TYPO3com voted on patch set 3 V +1 10/20/20, 10:38 Completed build in 23m 10s on Tue, 20 Oct, 10:38 AM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6688

  10. Oli Bartsch commented on patch set 3 10/28/20, 10:46

    SelectSingleElement.php:89

    Should we also deal with this var? See @todo in Line 91

    ContentObjectRenderer.php:4563

    Can we also remove this assignment and just add $linkParameterParts['url'] to the array (L:4573) directly as $linkParameter is not used elsewhere.
  11. Christian Kuhn commented on patch set 3 10/28/20, 11:16

    SelectSingleElement.php:89 Reply

    Mmmh, too complex decision for this patch, imho. Should be dedicated patch.

    ContentObjectRenderer.php:4563 Reply

    Done
  12. Christian Kuhn uploaded patch set 4 10/28/20, 11:17

  13. TYPO3com voted on patch set 4 V +1 10/28/20, 11:29 Completed build in 12m 13s on Wed, 28 Oct, 11:29 AM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6966

  14. Oli Bartsch commented on patch set 4 V +1 CR +1 10/28/20, 11:31

    SelectSingleElement.php:89 Reply

    Ack
  15. Daniel Goerz voted on patch set 4 V +2 CR +2 10/28/20, 12:00

  16. Daniel Goerz merged patch set 5 10/28/20, 12:00