66182[TASK] Drop a series of unused code occurences
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
-
Verified V +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 18
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php3+0 −1
- typo3/sysext/backend/Classes/Form/FieldControl/EditPopup.php+0 −12
- typo3/sysext/backend/Classes/Tree/View/ElementBrowserPageTreeView.php2+1 −2
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+0 −1
- typo3/sysext/core/Classes/Authentication/AuthenticationService.php+1 −2
- typo3/sysext/core/Classes/DependencyInjection/ContainerBuilder.php+0 −2
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+0 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+0 −3
- typo3/sysext/core/Classes/Resource/StorageRepository.php+0 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+1 −1
- typo3/sysext/filelist/Classes/FileList.php+1 −1
- typo3/sysext/form/Classes/Controller/FormManagerController.php+0 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderFormValueViewHelper.php+0 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php2+1 −4
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php+0 −1
- typo3/sysext/impexp/Classes/Import.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+0 −1
Review log 1216
-
Christian Kuhn uploaded patch set 1 10/19/20, 21:51
-
TYPO3com voted on patch set 1 V -1 10/19/20, 21:59 Completed build in 43s on Mon, 19 Oct, 09:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6676
-
Christian Kuhn uploaded patch set 2 10/19/20, 22:17
-
TYPO3com voted on patch set 2 V +1 10/19/20, 22:29 Completed build in 12m 15s on Mon, 19 Oct, 10:29 PM Test Summary: 73839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6678
-
Georg Ringer voted on patch set 2 CR +1 10/20/20, 06:10
-
Daniel Goerz commented on patch set 2 10/20/20, 08:39
-
Christian Kuhn uploaded patch set 3 10/20/20, 10:12
-
Christian Kuhn commented on patch set 3 10/20/20, 10:12
ElementBrowserPageTreeView.php:170ReplyDone -
TYPO3com voted on patch set 3 V +1 10/20/20, 10:38 Completed build in 23m 10s on Tue, 20 Oct, 10:38 AM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6688
-
Oli Bartsch commented on patch set 3 10/28/20, 10:46
SelectSingleElement.php:89Should we also deal with this var? See @todo in Line 91ContentObjectRenderer.php:4563Can we also remove this assignment and just add $linkParameterParts['url'] to the array (L:4573) directly as $linkParameter is not used elsewhere. -
Christian Kuhn commented on patch set 3 10/28/20, 11:16
SelectSingleElement.php:89ReplyMmmh, too complex decision for this patch, imho. Should be dedicated patch.ContentObjectRenderer.php:4563ReplyDone -
Christian Kuhn uploaded patch set 4 10/28/20, 11:17
-
TYPO3com voted on patch set 4 V +1 10/28/20, 11:29 Completed build in 12m 13s on Wed, 28 Oct, 11:29 AM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6966
-
Oli Bartsch commented on patch set 4 V +1 CR +1 10/28/20, 11:31
SelectSingleElement.php:89ReplyAck -
Daniel Goerz voted on patch set 4 V +2 CR +2 10/28/20, 12:00
-
Daniel Goerz merged patch set 5 10/28/20, 12:00
ElementBrowserPageTreeView.php:170