66190[TASK] Deprecate GeneralUtility::uniqueList
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Daniel Goerz +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Georg Ringer +2
- Daniel Goerz +1
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+2 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php1+15 −14
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+5 −0
- typo3/sysext/core/Classes/Utility/StringUtility.php2+12 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-92607-DeprecatedGeneralUtilityuniqueList.rstnew+43 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+0 −30
- typo3/sysext/core/Tests/Unit/Utility/StringUtilityTest.php+31 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 2434
Show 69 earlier messages
-
Oli Bartsch uploaded patch set 1 10/20/20, 09:06
-
Oli Bartsch updated the commit message in patch set 2 10/20/20, 09:07
-
TYPO3com voted on patch set 1 V -1 10/20/20, 09:16 Completed build in 10m 01s on Tue, 20 Oct, 09:16 AM Test Summary: 8630 of 73964 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6682
-
TYPO3com voted on patch set 2 V -1 10/20/20, 09:18 Completed build in 08m 52s on Tue, 20 Oct, 09:18 AM Test Summary: 8630 of 73964 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6683
-
Oli Bartsch uploaded patch set 3 10/20/20, 09:30
-
Oli Bartsch commented on patch set 3 V -1 10/20/20, 09:36
Will do it in another way -
Daniel Goerz wrote 10/20/20, 09:38
Topic set to phpstan -
Daniel Goerz uploaded patch set 4 10/20/20, 09:40
-
TYPO3com voted on patch set 3 V +1 10/20/20, 09:42 Completed build in 11m 51s on Tue, 20 Oct, 09:42 AM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6684
-
TYPO3com voted on patch set 4 V +1 10/20/20, 09:53 Completed build in 12m 30s on Tue, 20 Oct, 09:53 AM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6685
-
Oli Bartsch uploaded patch set 5 10/20/20, 10:09
-
Oli Bartsch updated the commit message in patch set 6 10/20/20, 10:10
-
Oli Bartsch uploaded patch set 7 10/20/20, 10:14
-
Oli Bartsch uploaded patch set 8 10/20/20, 10:18
-
TYPO3com voted on patch set 5 V +1 10/20/20, 10:27 Completed build in 17m 09s on Tue, 20 Oct, 10:27 AM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6686
-
TYPO3com voted on patch set 7 V +1 10/20/20, 10:31 Completed build in 16m 35s on Tue, 20 Oct, 10:31 AM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6689
-
TYPO3com voted on patch set 6 V -1 10/20/20, 10:42 Completed build in 27m 18s on Tue, 20 Oct, 10:42 AM Test Summary: 1 of 73964 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6687
-
TYPO3com voted on patch set 8 V +1 10/20/20, 10:47 Completed build in 16m 00s on Tue, 20 Oct, 10:47 AM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6690
-
Oliver Klee voted on patch set 8 CR +1 10/20/20, 10:55
-
Daniel Goerz voted on patch set 8 V +1 CR +1 10/20/20, 11:27
-
Oli Bartsch uploaded patch set 9 10/20/20, 11:55
-
Daniel Goerz voted on patch set 9 V +1 CR +1 10/20/20, 11:57
-
TYPO3com voted on patch set 9 V +1 10/20/20, 12:08 Completed build in 13m 03s on Tue, 20 Oct, 12:08 PM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6691
-
Daniel Haupt voted on patch set 9 CR +1 10/20/20, 12:42
-
Oliver Klee voted on patch set 9 CR +1 10/20/20, 14:04
-
Alexander Schnitzler commented on patch set 9 CR -1 10/20/20, 14:25
BackendUserAuthentication.php:1315UnresolvedThat case isn't covered by tests. Leading and trailing commas. Just want to make sure we know what happens in those cases. -
Alexander Schnitzler uploaded patch set 10 10/20/20, 14:31
-
Alexander Schnitzler commented on patch set 10 10/20/20, 14:33
StringUtility.php:161Another idea I will not push a patch set for. Since we are introducing a new method here, we could also make the delimiter variable. You decide whether you like the idea. -
TYPO3com voted on patch set 10 V +1 10/20/20, 14:45 Completed build in 13m 20s on Tue, 20 Oct, 02:45 PM Test Summary: 73503 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6697
-
Oli Bartsch commented on patch set 10 10/20/20, 15:36
StringUtility.php:161Reply UnresolvedLike the idea, but isn't that a feature then? Would suggest adding this as separate feature patch to not mix things here. -
Daniel Goerz voted on patch set 10 V +1 CR +1 10/20/20, 15:42
-
Alexander Schnitzler voted on patch set 10 V +1 CR +1 10/20/20, 16:25
-
Georg Ringer voted on patch set 10 V +2 CR +2 10/20/20, 16:48
-
Georg Ringer merged patch set 11 10/20/20, 16:48