Review main Merged

66190[TASK] Deprecate GeneralUtility::uniqueList

Oli Bartsch CR +2 V +2 Normal +115 −45 updated 10/20/20, 16:48

Commit message

Since over a decade (according to the timestamp),
GeneralUtility::uniqueList() does not allow an array as
first argument and furthermore doesn't use the second
parameter anymore. Since then, both have thrown an
`InvalidArgumentException`. Furthermore, this method
does not belong to GeneralUtility at all.

Therefore this method is now deprecated and a new one,
using proper type hints, a return type, no second argument
and a correct PHPDoc is added to StringUtility.

All usages in the core are replaced with the new method,
ensuring proper types.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 2434

Show 69 earlier messages
  1. Oli Bartsch uploaded patch set 1 10/20/20, 09:06

  2. Oli Bartsch updated the commit message in patch set 2 10/20/20, 09:07

  3. TYPO3com voted on patch set 1 V -1 10/20/20, 09:16 Completed build in 10m 01s on Tue, 20 Oct, 09:16 AM Test Summary: 8630 of 73964 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6682

  4. TYPO3com voted on patch set 2 V -1 10/20/20, 09:18 Completed build in 08m 52s on Tue, 20 Oct, 09:18 AM Test Summary: 8630 of 73964 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6683

  5. Oli Bartsch uploaded patch set 3 10/20/20, 09:30

  6. Oli Bartsch commented on patch set 3 V -1 10/20/20, 09:36

    Will do it in another way
  7. Daniel Goerz wrote 10/20/20, 09:38

    Topic set to phpstan
  8. Daniel Goerz uploaded patch set 4 10/20/20, 09:40

  9. TYPO3com voted on patch set 3 V +1 10/20/20, 09:42 Completed build in 11m 51s on Tue, 20 Oct, 09:42 AM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6684

  1. TYPO3com voted on patch set 4 V +1 10/20/20, 09:53 Completed build in 12m 30s on Tue, 20 Oct, 09:53 AM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6685

  2. Oli Bartsch uploaded patch set 5 10/20/20, 10:09

  3. Oli Bartsch updated the commit message in patch set 6 10/20/20, 10:10

  4. Oli Bartsch uploaded patch set 7 10/20/20, 10:14

  5. Oli Bartsch uploaded patch set 8 10/20/20, 10:18

  6. TYPO3com voted on patch set 5 V +1 10/20/20, 10:27 Completed build in 17m 09s on Tue, 20 Oct, 10:27 AM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6686

  7. TYPO3com voted on patch set 7 V +1 10/20/20, 10:31 Completed build in 16m 35s on Tue, 20 Oct, 10:31 AM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6689

  8. TYPO3com voted on patch set 6 V -1 10/20/20, 10:42 Completed build in 27m 18s on Tue, 20 Oct, 10:42 AM Test Summary: 1 of 73964 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6687

  9. TYPO3com voted on patch set 8 V +1 10/20/20, 10:47 Completed build in 16m 00s on Tue, 20 Oct, 10:47 AM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6690

  10. Oliver Klee voted on patch set 8 CR +1 10/20/20, 10:55

  11. Daniel Goerz voted on patch set 8 V +1 CR +1 10/20/20, 11:27

  12. Oli Bartsch uploaded patch set 9 10/20/20, 11:55

  13. Daniel Goerz voted on patch set 9 V +1 CR +1 10/20/20, 11:57

  14. TYPO3com voted on patch set 9 V +1 10/20/20, 12:08 Completed build in 13m 03s on Tue, 20 Oct, 12:08 PM Test Summary: 73479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6691

  15. Daniel Haupt voted on patch set 9 CR +1 10/20/20, 12:42

  16. Oliver Klee voted on patch set 9 CR +1 10/20/20, 14:04

  17. Alexander Schnitzler commented on patch set 9 CR -1 10/20/20, 14:25

    BackendUserAuthentication.php:1315 Unresolved

    That case isn't covered by tests. Leading and trailing commas. Just want to make sure we know what happens in those cases.
  18. Alexander Schnitzler uploaded patch set 10 10/20/20, 14:31

  19. Alexander Schnitzler commented on patch set 10 10/20/20, 14:33

    StringUtility.php:161

    Another idea I will not push a patch set for. Since we are introducing a new method here, we could also make the delimiter variable. You decide whether you like the idea.
  20. TYPO3com voted on patch set 10 V +1 10/20/20, 14:45 Completed build in 13m 20s on Tue, 20 Oct, 02:45 PM Test Summary: 73503 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6697

  21. Oli Bartsch commented on patch set 10 10/20/20, 15:36

    StringUtility.php:161 Reply Unresolved

    Like the idea, but isn't that a feature then? Would suggest adding this as separate feature patch to not mix things here.
  22. Daniel Goerz voted on patch set 10 V +1 CR +1 10/20/20, 15:42

  23. Alexander Schnitzler voted on patch set 10 V +1 CR +1 10/20/20, 16:25

  24. Georg Ringer voted on patch set 10 V +2 CR +2 10/20/20, 16:48

  25. Georg Ringer merged patch set 11 10/20/20, 16:48