66194[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend Form
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
-
Verified V +2 Done
- Daniel Goerz +2
- TYPO3com +1 CI
Issues 1
Files 30
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+3 −3
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+5 −5
- typo3/sysext/backend/Classes/Form/Element/FileInfoElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/InputDateTimeElement.php+4 −4
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+4 −4
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+12 −12
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+4 −4
- typo3/sysext/backend/Classes/Form/Element/TextTableElement.php+4 −4
- typo3/sysext/backend/Classes/Form/Element/UserSysFileStorageIsPublicElement.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldWizard/DefaultLanguageDifferences.php+2 −2
- typo3/sysext/backend/Classes/Form/FieldWizard/OtherLanguageContent.php+2 −2
Show 10 more files
- typo3/sysext/backend/Classes/Form/FieldWizard/OtherLanguageThumbnails.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+3 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseParentPageRow.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowDateTimeFields.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteTcaInline.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaGroup.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+2 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaTypesShowitem.php+1 −1
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php+1 −1
Review log 814
-
Daniel Goerz commented on patch set 1 10/19/20, 21:38
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php -
TYPO3com voted on patch set 1 V -1 10/19/20, 21:40 Completed build in 44s on Mon, 19 Oct, 09:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-650
-
Daniel Goerz uploaded patch set 2 10/19/20, 21:40
-
Daniel Goerz commented on patch set 2 10/19/20, 21:40
This change is ready for review. -
TYPO3com voted on patch set 2 V +1 10/19/20, 22:06 Completed build in 19m 06s on Mon, 19 Oct, 10:05 PM Test Summary: 74850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-651
-
Daniel Goerz commented on patch set 2 V -1 10/20/20, 08:10
gonna check some things -
Daniel Goerz uploaded patch set 3 10/20/20, 10:04
-
TYPO3com voted on patch set 3 V -1 10/20/20, 10:20 Completed build in 16m 08s on Tue, 20 Oct, 10:20 AM Test Summary: 1 of 75336 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-655
-
TYPO3com commented on patch set 3 10/20/20, 11:15 Completed build in 1h 26m 33s on Tue, 20 Oct, 11:15 AM Test Summary: 74849 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-655
-
TYPO3com voted on patch set 3 V +1 10/20/20, 11:28 Completed build in 2h 49m 49s on Tue, 20 Oct, 11:28 AM Test Summary: 74849 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-655
-
Daniel Goerz uploaded patch set 4 10/20/20, 11:31
-
TYPO3com voted on patch set 4 V +1 10/20/20, 11:49 Completed build in 17m 13s on Tue, 20 Oct, 11:49 AM Test Summary: 74850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-656
-
Daniel Goerz voted on patch set 4 V +2 CR +2 10/20/20, 11:57
-
Daniel Goerz merged patch set 5 10/20/20, 11:57