Review 10.4 Merged

66194[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend Form

Daniel Goerz CR +2 V +2 Normal +70 −68 updated 10/20/20, 11:57

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 30

Show 10 more files

Review log 814

  1. Daniel Goerz commented on patch set 1 10/19/20, 21:38

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php
  2. TYPO3com voted on patch set 1 V -1 10/19/20, 21:40 Completed build in 44s on Mon, 19 Oct, 09:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-650

  3. Daniel Goerz uploaded patch set 2 10/19/20, 21:40

  4. Daniel Goerz commented on patch set 2 10/19/20, 21:40

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 10/19/20, 22:06 Completed build in 19m 06s on Mon, 19 Oct, 10:05 PM Test Summary: 74850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-651

  6. Daniel Goerz commented on patch set 2 V -1 10/20/20, 08:10

    gonna check some things
  7. Daniel Goerz uploaded patch set 3 10/20/20, 10:04

  8. TYPO3com voted on patch set 3 V -1 10/20/20, 10:20 Completed build in 16m 08s on Tue, 20 Oct, 10:20 AM Test Summary: 1 of 75336 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-655

  9. TYPO3com commented on patch set 3 10/20/20, 11:15 Completed build in 1h 26m 33s on Tue, 20 Oct, 11:15 AM Test Summary: 74849 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-655

  10. TYPO3com voted on patch set 3 V +1 10/20/20, 11:28 Completed build in 2h 49m 49s on Tue, 20 Oct, 11:28 AM Test Summary: 74849 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-655

  11. Daniel Goerz uploaded patch set 4 10/20/20, 11:31

  12. TYPO3com voted on patch set 4 V +1 10/20/20, 11:49 Completed build in 17m 13s on Tue, 20 Oct, 11:49 AM Test Summary: 74850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-656

  13. Daniel Goerz voted on patch set 4 V +2 CR +2 10/20/20, 11:57

  14. Daniel Goerz merged patch set 5 10/20/20, 11:57