Review 10.4 Merged

66195[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend Controller

Benni Mack CR +2 V +2 Normal +44 −38 updated 10/20/20, 09:56

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 45

  1. Benni Mack commented on patch set 1 10/20/20, 08:00

    Cherry Picked from branch master.
  2. Daniel Goerz commented on patch set 1 V -1 10/20/20, 08:09

    Gonna check some things
  3. TYPO3com voted on patch set 1 V +1 10/20/20, 08:12 Completed build in 11m 37s on Tue, 20 Oct, 08:12 AM Test Summary: 74850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-653

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 10/20/20, 09:56

  5. Daniel Goerz merged patch set 2 10/20/20, 09:56