Review 10.4 Merged

66204[BUGFIX] Fix PHP type error in f:form.select.optgroup view helper

Daniel Goerz CR +2 V +2 Easy +1 −1 updated 10/22/20, 10:27

Commit message

Using view helper `f:form.select.optgroup` with argument `disabled`
throws PHP type error, since array is expected, but string given.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 10/22/20, 10:11

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/22/20, 10:24 Completed build in 13m 07s on Thu, 22 Oct, 10:24 AM Test Summary: 74850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-672

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 10/22/20, 10:27

  4. Daniel Goerz merged patch set 2 10/22/20, 10:27