Review 10.4 Merged

66207[BUGFIX] Ensure getUniqueId returns unique ids for grid objects

Christian Kuhn CR +2 V +2 Easy +1 −6 updated 10/22/20, 16:17

Commit message

The fluid based page module tried to return a "unique id" for each
"create content element" button using the `getUniqueId` method.
This id however was not unique as it was stored as class property
after the first creation.

This lead to all buttons got the same ID which is according to the spec
https://html.spec.whatwg.org/multipage/dom.html#the-id-attribute not
allowed.

Therefore the `getUniqueId()` method now returns a new "unique id"
on each call.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Christian Kuhn commented on patch set 1 10/22/20, 15:53

    Cherry Picked from branch master.
  2. Christian Kuhn uploaded patch set 2 10/22/20, 15:54

  3. TYPO3com voted on patch set 1 V +1 10/22/20, 16:08 Completed build in 14m 01s on Thu, 22 Oct, 04:08 PM Test Summary: 74856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-675

  4. Christian Kuhn voted on patch set 2 V +2 CR +2 10/22/20, 16:09

  5. Christian Kuhn merged patch set 3 10/22/20, 16:09

  6. TYPO3com commented on patch set 2 10/22/20, 16:17 Completed build in 22m 14s on Thu, 22 Oct, 04:17 PM Test Summary: 74856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-676