Review 10.4 Merged

66208[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend Tree

Daniel Goerz CR +2 V +2 Easy +28 −20 updated 10/23/20, 08:59

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 57

  1. Daniel Goerz commented on patch set 1 10/23/20, 08:31

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Tree/View/FolderTreeView.php
  2. TYPO3com voted on patch set 1 V -1 10/23/20, 08:32 Completed build in 28s on Fri, 23 Oct, 08:32 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-678

  3. Daniel Goerz uploaded patch set 2 10/23/20, 08:45

  4. Daniel Goerz commented on patch set 2 10/23/20, 08:45

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 10/23/20, 08:58 Completed build in 12m 40s on Fri, 23 Oct, 08:58 AM Test Summary: 74856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-679

  6. Daniel Goerz voted on patch set 2 V +2 CR +2 10/23/20, 08:59

  7. Daniel Goerz merged patch set 3 10/23/20, 08:59