Review 10.4 Merged

66211[BUGFIX] Use type "button" for accessible paste content buttons

Daniel Goerz CR +2 V +2 Easy +4 −2 updated 10/25/20, 16:19

Commit message

The paste content buttons now have the type "button" set
to not falsely behave as submit buttons, which is the default
if no type is defined.

See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attr-type

Note: In this case the regular submit event is prevented by
JavaScript which leads to no actual functional change here.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Daniel Haupt +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Daniel Goerz commented on patch set 1 10/25/20, 16:04

    Cherry Picked from branch master.
  2. Daniel Haupt voted on patch set 1 V +1 CR +1 10/25/20, 16:06

  3. TYPO3com voted on patch set 1 V +1 10/25/20, 16:16 Completed build in 11m 50s on Sun, 25 Oct, 04:16 PM Test Summary: 74856 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-681

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 10/25/20, 16:19

  5. Daniel Goerz merged patch set 2 10/25/20, 16:19