66215[BUGFIX] Allow integers as argument name
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
Review log 1415
-
Georg Ringer uploaded patch set 1 10/20/20, 20:50
-
Georg Ringer commented on patch set 1 10/20/20, 20:50
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 10/20/20, 21:03 Completed build in 12m 40s on Tue, 20 Oct, 09:03 PM Test Summary: 73509 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6705
-
Christian Kuhn voted on patch set 1 CR +1 10/20/20, 21:08
-
Markus Klein commented on patch set 1 V +1 CR +1 10/21/20, 07:36
I don't get at the moment why the `name` attribute of the text -
Oli Bartsch commented on patch set 1 10/21/20, 07:56
RequestTest.php:41UnresolvedIs this test related to the patch? Integer was also possible as value beforehand and as the expected type is mixed and is not checked at all this test seems to be superfluous. I would suggest adding a test using an integer as argumentName (first parameter) instead. $request->setArgument(123, 'someValue') -
Daniel Goerz commented on patch set 1 CR -1 10/21/20, 07:59
Request.php:366UnresolvedThis will trigger a notice in PHP 7.4 when $argumentName is an integer "Notice: Trying to access array offset on value of type int". It will trigger a warning in PHP 8. https://3v4l.org/jv8rX -
Markus Klein voted on patch set 1 V 0 CR 0 10/21/20, 08:08
-
Alexander Schnitzler commented on patch set 1 CR -1 10/21/20, 08:09
Sorry but I need a more detailed explanation here why this change is necessary. I mean like a real world example and not just a link to the specs. I don't want to block, I want to understand this change. -
Alexander Schnitzler wrote 10/21/20, 08:10
Topic set to extbase -
Christian Kuhn voted on patch set 1 CR 0 10/21/20, 08:43
-
Markus Klein commented on patch set 1 10/21/20, 08:54
> Patch Set 1: Code-Review-1 > > Sorry but I need a more detailed explanation here why this change is necessary. I mean like a real world example and not just a link to the specs. I don't want to block, I want to understand this change. As I understood from the ticket: Form is created dynamically with textfields, who's names are a number. Those are then dynamically processed within an action in extbase. The request must therefore allow to store the data. -
Alexander Schnitzler commented on patch set 1 10/21/20, 09:57
I am still not convinced this is the right fix. Please give me some time to investigate this. Won't be today, rather friday. I want to see a real life example here and understand why we end up with integers in the first place instead of numeric strings. IMHO names are always strings. Allowing integers may fix the issue but my approach is to dig a little deeper and have something more type safe. -
Markus Klein commented on patch set 1 10/21/20, 11:50
> IMHO names are always strings. Allowing integers may fix the issue but my approach is to dig a little deeper and have something more type safe. True. This is really interesting. Thanks for digging. -
Georg Ringer abandoned the change 10/19/21, 18:46
abandoned, no solution found