Review main Merged

66217[BUGFIX] Restore translations in EXT:fluid

Georg Ringer CR +2 V +2 Easy +11 −0 updated 10/21/20, 09:45

Commit message

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Markus Klein +1
    • Björn Jacob +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Markus Klein +1
    • Björn Jacob +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1618

  1. Georg Ringer uploaded patch set 1 10/21/20, 08:24

  2. Georg Ringer commented on patch set 1 10/21/20, 08:24

    This change is ready for review.
  3. Josef Glatz voted on patch set 1 V +1 CR +1 10/21/20, 08:28

  4. Wouter Wolters voted on patch set 1 CR +1 10/21/20, 08:30

  5. TYPO3com voted on patch set 1 V +1 10/21/20, 08:36 Completed build in 12m 00s on Wed, 21 Oct, 08:36 AM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6711

  6. Markus Klein voted on patch set 1 V +1 CR +1 10/21/20, 08:37

  7. Christian Kuhn commented on patch set 1 CR -1 10/21/20, 08:42

    If this is a regression from another patch, please set a 'Related: #' in the commit message.
  8. Georg Ringer updated the commit message in patch set 2 10/21/20, 08:47

  9. Björn Jacob voted on patch set 2 V +1 CR +1 10/21/20, 08:52

  10. Markus Klein voted on patch set 2 V +1 CR +1 10/21/20, 08:55

  11. Benni Mack commented on patch set 2 10/21/20, 08:58

    Check out GeneralUtility::formatSize()
  12. TYPO3com voted on patch set 2 V +1 10/21/20, 09:01 Completed build in 13m 40s on Wed, 21 Oct, 09:01 AM Test Summary: 73486 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6712

  13. Georg Ringer commented on patch set 2 10/21/20, 09:28

    @benni: problem is BytesViewHelper which uses it
  14. Alexander Schnitzler voted on patch set 2 V +1 CR +1 10/21/20, 09:29

  15. Josef Glatz voted on patch set 2 V +1 CR +1 10/21/20, 09:30

  16. Oli Bartsch voted on patch set 2 V +1 CR +1 10/21/20, 09:37

  17. Daniel Goerz voted on patch set 2 V +2 CR +2 10/21/20, 09:45

  18. Daniel Goerz merged patch set 3 10/21/20, 09:45