Review 9.5 Merged

66218[BUGFIX] Mark page for previewing when admin panel is active

Benni Mack CR +2 V +2 Easy +15 −9 updated 10/30/20, 11:17

Commit message

When the admin panel is active, the rendered page should always
be marked as "preview mode" so TSFE will later set
TSFE->no_cache which then allows to not store anything
in the Page cache.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • Sybille Peters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 10/21/20, 09:56

  2. TYPO3com voted on patch set 1 V +1 10/21/20, 10:12 Completed build in 16m 02s on Wed, 21 Oct, 10:12 AM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-844

  3. Sybille Peters voted on patch set 1 V +1 10/21/20, 11:01

  4. Benni Mack voted on patch set 1 V +2 CR +2 10/27/20, 11:11

  5. Benni Mack merged patch set 2 10/27/20, 11:11

  6. Xavier Perseguers commented on patch set 2 10/30/20, 11:17

    Post -1 by testing: this breaks the frontend when the admin panel is not available.