Review main Merged

66220[BUGFIX] Ensure getUniqueId returns unique ids for grid objects

Oli Bartsch CR +2 V +2 Easy +1 −6 updated 10/22/20, 15:52

Commit message

The fluid based page module tried to return a "unique id" for each
"create content element" button using the `getUniqueId` method.
This id however was not unique as it was stored as class property
after the first creation.

This lead to all buttons got the same ID which is according to the spec
https://html.spec.whatwg.org/multipage/dom.html#the-id-attribute not
allowed.

Therefore the `getUniqueId()` method now returns a new "unique id"
on each call.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Josef Glatz +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1215

  1. Oli Bartsch uploaded patch set 1 10/21/20, 10:50

  2. TYPO3com voted on patch set 1 V +1 10/21/20, 11:03 Completed build in 13m 09s on Wed, 21 Oct, 11:03 AM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6718

  3. Oli Bartsch commented on patch set 1 10/21/20, 11:16

    Because the generated id is now not longer stored as class property, this method is basically just a helper method used in the view (without any context to the actual object). Therefore this could also be implemented as ViewHelper. For this use-case and since it's a bugfix patch, I think it would not be reasonable to introduce such new ViewHelper now. But I'm completely open for suggestions :)
  4. Oli Bartsch wrote 10/21/20, 11:23

    Hashtag added: a11y
  5. Oli Bartsch wrote 10/21/20, 11:23

    Hashtag removed: a11y
  6. Oli Bartsch wrote 10/21/20, 11:23

    Topic set to a11y
  7. Oli Bartsch updated the commit message in patch set 2 10/21/20, 11:41

  8. TYPO3com voted on patch set 2 V +1 10/21/20, 12:06 Completed build in 15m 26s on Wed, 21 Oct, 12:06 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6723

  9. Josef Glatz updated the commit message in patch set 3 10/21/20, 13:57

  10. Josef Glatz voted on patch set 3 CR +1 10/21/20, 13:58

  11. TYPO3com voted on patch set 3 V +1 10/21/20, 14:09 Completed build in 11m 33s on Wed, 21 Oct, 02:09 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6739

  12. Georg Ringer voted on patch set 3 V +1 CR +1 10/21/20, 16:07

  13. Daniel Goerz voted on patch set 3 CR +1 10/21/20, 17:42

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 10/22/20, 15:52

  15. Christian Kuhn merged patch set 4 10/22/20, 15:52