Review main Merged

66221[BUGFIX] TCA foreign_table_where on some l10n_parent fields

Christian Kuhn CR +2 V +2 Easy +4 −4 updated 12/03/20, 19:31

Commit message

A couple of foreign_table_where TCA fields for l10n_parent
do not allow setting a localized element to a different
parent element located on the same page.
Solution is to use the same foreign_table_where strategy
as used with other tables like tt_content.
Note this is only visible for sys_category since the
two fal related tables do not show that field at all.
Those two are still changed to streamline core code and
to not deliver broken examples.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1013

  1. Christian Kuhn uploaded patch set 1 10/21/20, 10:56

  2. TYPO3com voted on patch set 1 V +1 10/21/20, 11:13 Completed build in 16m 42s on Wed, 21 Oct, 11:13 AM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6719

  3. Oli Bartsch updated the commit message in patch set 2 10/21/20, 11:40

  4. Oli Bartsch updated the commit message in patch set 3 10/21/20, 11:41

  5. Oli Bartsch voted on patch set 3 V +1 CR +1 10/21/20, 11:54

  6. TYPO3com voted on patch set 2 V +1 10/21/20, 12:00 Completed build in 20m 00s on Wed, 21 Oct, 12:00 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6721

  7. TYPO3com voted on patch set 3 V +1 10/21/20, 12:02 Completed build in 21m 16s on Wed, 21 Oct, 12:02 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6722

  8. Daniel Goerz voted on patch set 3 V +2 CR +2 10/25/20, 16:14

  9. Daniel Goerz merged patch set 4 10/25/20, 16:14

  10. Markus Klein commented on patch set 4 11/17/20, 16:16

    This makes the Core unusable! Talking about an instance with thousands of images in 30k news articles. sys_file_references are all on the same pid of course
  11. Oliver Hader commented on patch set 4 12/03/20, 16:50

    →(not verified) I assume(!) this change introduced a regression as described in https://forge.typo3.org/issues/92873
  12. Markus Klein commented on patch set 4 12/03/20, 19:30

    > Patch Set 4: > > →(not verified) I assume(!) this change introduced a regression as described in https://forge.typo3.org/issues/92873 By reading I would rather assume this change https://review.typo3.org/c/Packages/TYPO3.CMS/+/66293/2/typo3/sysext/core/Configuration/TCA/sys_file_reference.php#68 is causing the issue, because the l10n_parent of a page is probably not stored on the same pid
  13. Markus Klein commented on patch set 4 12/03/20, 19:31

    > Patch Set 4: > > > Patch Set 4: > > > > →(not verified) I assume(!) this change introduced a regression as described in https://forge.typo3.org/issues/92873 > > By reading I would rather assume this change https://review.typo3.org/c/Packages/TYPO3.CMS/+/66293/2/typo3/sysext/core/Configuration/TCA/sys_file_reference.php#68 is causing the issue, because the l10n_parent of a page is probably not stored on the same pid Forget my last comment, it's of course the same patch (backport) ....