Review main Merged

66223[BUGFIX] Remove invalid alt attribute from span elements

Georg Ringer CR +2 V +2 Easy +3 −3 updated 10/21/20, 16:59

Commit message

Attribute alt is not allowed on span elements.

See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/span#Attributes

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Daniel Haupt +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1619

  1. Georg Ringer uploaded patch set 1 10/21/20, 11:51

  2. Georg Ringer commented on patch set 1 10/21/20, 11:51

    This change is ready for review.
  3. Oliver Klee voted on patch set 1 CR +1 10/21/20, 11:54

  4. Oli Bartsch uploaded patch set 2 10/21/20, 12:00

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 10/21/20, 12:02

  6. TYPO3com voted on patch set 1 V +1 10/21/20, 12:10 Completed build in 18m 36s on Wed, 21 Oct, 12:09 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6724

  7. TYPO3com voted on patch set 2 V +1 10/21/20, 12:15 Completed build in 14m 02s on Wed, 21 Oct, 12:15 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6725

  8. Josef Glatz voted on patch set 2 V +1 CR +1 10/21/20, 13:06

  9. Olaf Schmidt-Wischhöfer voted on patch set 2 CR +1 10/21/20, 13:36

  10. Guido Schmechel voted on patch set 2 CR +1 10/21/20, 13:37

  11. Daniel Goerz commented on patch set 2 10/21/20, 16:15

    Why no backport to v10?
  12. Daniel Goerz updated the commit message in patch set 3 10/21/20, 16:15

  13. Daniel Goerz voted on patch set 3 V +1 CR +1 10/21/20, 16:16

  14. Josef Glatz voted on patch set 3 V +1 CR +1 10/21/20, 16:16

  15. TYPO3com voted on patch set 3 V +1 10/21/20, 16:41 Completed build in 25m 22s on Wed, 21 Oct, 04:41 PM Test Summary: 73485 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6751

  16. Daniel Haupt voted on patch set 3 V +1 CR +1 10/21/20, 16:48

  17. Oli Bartsch voted on patch set 3 V +1 CR +1 10/21/20, 16:58

  18. Daniel Goerz voted on patch set 3 V +2 CR +2 10/21/20, 16:59

  19. Daniel Goerz merged patch set 4 10/21/20, 16:59