66225[BUGFIX] Remove invalid attribute alt from textareas
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Josef Glatz +1
- Oli Bartsch +1
- Markus Klein +1
- Daniel Haupt +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Markus Klein +1
- Daniel Haupt +1
- Michael Telgkamp +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2022
-
Georg Ringer uploaded patch set 1 10/21/20, 12:03
-
Georg Ringer commented on patch set 1 10/21/20, 12:03
This change is ready for review. -
Georg Ringer wrote 10/21/20, 12:03
Topic set to a11y -
TYPO3com voted on patch set 1 V +1 10/21/20, 12:24 Completed build in 19m 45s on Wed, 21 Oct, 12:24 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6727
-
Olaf Schmidt-Wischhöfer commented on patch set 1 10/21/20, 13:42
T3editorElement.php:123Is removing this line intentional? I find nothing about it in the commit message. -
Josef Glatz voted on patch set 1 CR -1 10/21/20, 13:56
-
Georg Ringer commented on patch set 1 10/21/20, 13:57
T3editorElement.php:123Replythis is the alt tag which is not needed anymore -
Olaf Schmidt-Wischhöfer commented on patch set 1 CR +1 10/21/20, 14:00
T3editorElement.php:123ReplyAck -
Josef Glatz voted on patch set 1 CR 0 10/21/20, 14:01
-
Daniel Goerz voted on patch set 1 CR +1 10/21/20, 17:41
-
Josef Glatz commented on patch set 1 10/21/20, 19:48
Wht about 10.4 since other were also backported? -
Georg Ringer updated the commit message in patch set 2 10/21/20, 20:04
-
TYPO3com voted on patch set 2 V +1 10/21/20, 20:26 Completed build in 18m 08s on Wed, 21 Oct, 08:26 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6763
-
Daniel Goerz commented on patch set 2 10/21/20, 21:15
Actually, I was fine with this one being master only as this could potentially break XClasses. Not likely, but still. -
Daniel Haupt voted on patch set 2 V +1 CR +1 10/21/20, 23:50
-
Josef Glatz voted on patch set 2 CR +1 10/22/20, 03:31
-
Michael Telgkamp voted on patch set 2 V +1 CR +1 10/22/20, 06:48
-
Markus Klein voted on patch set 2 V +1 CR +1 10/22/20, 07:01
-
Oli Bartsch voted on patch set 2 V +1 CR +1 10/22/20, 07:37
-
Daniel Goerz commented on patch set 2 V +2 CR +2 10/22/20, 07:43
Backport is fine as this class is @internal -
Daniel Goerz merged patch set 3 10/22/20, 07:43
-
Benjamin Franzke commented on patch set 3 12/19/20, 11:59
This change caused a slight regression. The alt tag was implictly used as codemirror panel label. See: https://forge.typo3.org/issues/93115 Bugfix is here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67189