Review main Merged

66229[BUGFIX] Replace shorthand ternary operator in CheckboxElement

Georg Ringer CR +2 V +2 Easy +2 −2 updated 10/21/20, 16:39

Commit message

Instead of using the shorthand ternary operator use a regular ternary
operator to avoid an invalid HTML attribute '1'.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1214

  1. Georg Ringer uploaded patch set 1 10/21/20, 12:49

  2. Georg Ringer commented on patch set 1 10/21/20, 12:50

    This change is ready for review.
  3. Josef Glatz voted on patch set 1 CR +1 10/21/20, 12:56

  4. TYPO3com voted on patch set 1 V +1 10/21/20, 13:01 Completed build in 11m 57s on Wed, 21 Oct, 01:01 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6732

  5. Olaf Schmidt-Wischhöfer voted on patch set 1 CR +1 10/21/20, 13:39

  6. Daniel Goerz voted on patch set 1 V +1 CR +1 10/21/20, 16:10

  7. Daniel Goerz commented on patch set 1 10/21/20, 16:11

    10 should be fixed as well
  8. Daniel Goerz updated the commit message in patch set 2 10/21/20, 16:11

  9. Daniel Goerz voted on patch set 2 V +1 CR +1 10/21/20, 16:11

  10. Josef Glatz voted on patch set 2 V +1 CR +1 10/21/20, 16:15

  11. Oli Bartsch voted on patch set 2 V +1 CR +1 10/21/20, 16:20

  12. TYPO3com voted on patch set 2 V +1 10/21/20, 16:37 Completed build in 21m 47s on Wed, 21 Oct, 04:37 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6750

  13. Daniel Goerz voted on patch set 2 V +2 CR +2 10/21/20, 16:38

  14. Daniel Goerz merged patch set 3 10/21/20, 16:39