66233[BUGFIX] Use button tag for modal buttons in InlineControlContainer
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Martin Kutschker +1
- Torben Hansen +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Benni Mack +2
- Martin Kutschker +1
- Michael Telgkamp +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 3849
Show 1824 earlier messages
-
Olaf Schmidt-Wischhöfer uploaded patch set 1 10/21/20, 13:12
-
Georg Ringer updated the commit message in patch set 2 10/21/20, 13:15
-
Georg Ringer wrote 10/21/20, 13:16
Topic set to a11y -
TYPO3com voted on patch set 1 V +1 10/21/20, 13:37 Completed build in 23m 44s on Wed, 21 Oct, 01:37 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6736
-
TYPO3com voted on patch set 2 V +1 10/21/20, 13:41 Completed build in 16m 45s on Wed, 21 Oct, 01:41 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6737
-
Georg Ringer voted on patch set 2 V +1 CR +1 10/21/20, 20:06
-
Oli Bartsch commented on patch set 2 V -1 10/21/20, 21:35
Hi, thanks for your contribution. I had a look at your patch and there seems to be a problem with the "add online media button" now (independent of the missing closing tag). What I did: * Go into page properties (Tab Resources) * Click "Create new relation" and add a media file * Click "Select & Upload files" and upload a media file * Click "Add media by Url" => Here now the whole FormEngine reloads and the previously added media files are gone. Furthermore after inserting a url, it can not be added as the "Add media" button does not react. Could you please have a look at this? And just an idea. What do you think about also fixing the a-tags in InlineRecordContainer?InlineControlContainer.php:456UnresolvedHere we should also ensure no <a href="#"> tags are generated.InlineControlContainer.php:582Must also be </button> then. -
Olaf Schmidt-Wischhöfer uploaded patch set 3 10/22/20, 09:21
-
TYPO3com voted on patch set 3 V -1 10/22/20, 09:22 Completed build in 20s on Thu, 22 Oct, 09:22 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6779
-
Olaf Schmidt-Wischhöfer commented on patch set 3 10/22/20, 09:23
> What I did: > * Go into page properties (Tab Resources) > * Click "Create new relation" and add a media file > * Click "Select & Upload files" and upload a media file > * Click "Add media by Url" => Here now the whole FormEngine reloads and the previously added media files are gone. Furthermore after inserting a url, it can not be added as the "Add media" button does not react. > > Could you please have a look at this? Thank you for your review and test. I have fixed this problem with "Add media by Url". > And just an idea. What do you think about also fixing the a-tags in InlineRecordContainer? I also include the from wrapWithAnchor now. -
Olaf Schmidt-Wischhöfer commented on patch set 3 10/22/20, 09:25
InlineControlContainer.php:582ReplyDone -
Olaf Schmidt-Wischhöfer uploaded patch set 4 10/22/20, 09:26
-
TYPO3com voted on patch set 4 V +1 10/22/20, 09:40 Completed build in 13m 44s on Thu, 22 Oct, 09:40 AM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6780
-
Olaf Schmidt-Wischhöfer uploaded patch set 5 10/22/20, 09:42
-
Oliver Klee commented on patch set 5 CR -1 10/22/20, 09:46
InlineControlContainer.php:545We also need to add type="button" to all those new buttons so that they do not work as submit buttons (which is the default behavior, see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button ). -
Oli Bartsch commented on patch set 5 V -1 10/22/20, 09:51
There seems to be no change in the code (comparing https://review.typo3.org/c/Packages/TYPO3.CMS/+/66233/2..5) -
Olaf Schmidt-Wischhöfer uploaded patch set 6 10/22/20, 09:57
-
Olaf Schmidt-Wischhöfer commented on patch set 6 10/22/20, 09:58
> There seems to be no change in the code (comparing https://review.typo3.org/c/Packages/TYPO3.CMS/+/66233/2..5) Yes, I used the wrong patch set when rebasing onto current master. Sorry. I have redone this now. -
TYPO3com voted on patch set 5 V +1 10/22/20, 10:03 Completed build in 21m 16s on Thu, 22 Oct, 10:03 AM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6782
-
TYPO3com voted on patch set 6 V +1 10/22/20, 10:11 Completed build in 13m 56s on Thu, 22 Oct, 10:11 AM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6783
-
Olaf Schmidt-Wischhöfer commented on patch set 6 10/22/20, 13:09
> Patch Set 5: Code-Review-1 > > (1 comment)InlineControlContainer.php:545ReplyDone -
Oliver Klee commented on patch set 6 CR -1 10/22/20, 13:34
InlineControlContainer.php:456I find the change confusing as the method now wraps with either an anchor or a button. I propose we use two different methods now - one for anchors and one for buttons. -
Olaf Schmidt-Wischhöfer uploaded patch set 7 10/22/20, 13:54
-
Oliver Klee commented on patch set 7 10/22/20, 13:56
InlineControlContainer.php:455There's the preposition missing: wrapButton -> wrapWithButton (or wrapInButton) Please also use type declarations for the parameters.
-
Olaf Schmidt-Wischhöfer uploaded patch set 8 10/22/20, 13:57
-
Olaf Schmidt-Wischhöfer uploaded patch set 9 10/22/20, 14:01
-
Olaf Schmidt-Wischhöfer commented on patch set 9 10/22/20, 14:02
InlineControlContainer.php:455ReplyDoneInlineControlContainer.php:456Reply UnresolvedOK, I have added a new method wrapWithButton. But wrapWithAnchor seems unused now – unless there is a sub-class somewhere using it. Should I remove the method? -
TYPO3com voted on patch set 7 V -1 10/22/20, 14:10 Completed build in 15m 45s on Thu, 22 Oct, 02:10 PM Test Summary: 73034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6798
-
TYPO3com voted on patch set 8 V +1 10/22/20, 14:15 Completed build in 18m 24s on Thu, 22 Oct, 02:15 PM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6799
-
TYPO3com voted on patch set 9 V +1 10/22/20, 14:21 Completed build in 16m 57s on Thu, 22 Oct, 02:21 PM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6801
-
Michael Telgkamp commented on patch set 9 CR -1 10/22/20, 21:11
The variable names and the comments should reflect the change from links to buttons as well.InlineControlContainer.php:399I would suggest to also change the description and use `button` here instead of `link`InlineControlContainer.php:401also the function name should represent the change and be renamed to getLevelInteractionButtonInlineControlContainer.php:444I would suggest to rename the variable from $link to $button (also in the comment)InlineControlContainer.php:479The html generated is an HTML button now -
Olaf Schmidt-Wischhöfer uploaded patch set 10 10/23/20, 07:24
-
Olaf Schmidt-Wischhöfer commented on patch set 10 10/23/20, 07:26
InlineControlContainer.php:399ReplyDoneInlineControlContainer.php:401ReplyDoneInlineControlContainer.php:444ReplyDoneInlineControlContainer.php:479ReplyDone -
TYPO3com voted on patch set 10 V +1 10/23/20, 07:36 Completed build in 11m 34s on Fri, 23 Oct, 07:36 AM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6817
-
Oliver Klee voted on patch set 10 CR +1 10/23/20, 07:42
-
Martin Kutschker voted on patch set 10 CR +1 10/25/20, 17:29
-
Oli Bartsch commented on patch set 10 CR -1 10/26/20, 10:15
Please use proper linebreaks in the commit message. See: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html?#commit-message-rules-for-typo3-cms -
Olaf Schmidt-Wischhöfer updated the commit message in patch set 11 10/26/20, 10:30
-
Olaf Schmidt-Wischhöfer commented on patch set 11 10/26/20, 10:35
> Please use proper linebreaks in the commit message. See: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html?#commit-message-rules-for-typo3-cms OK, I have done so. -
TYPO3com voted on patch set 11 V +1 10/26/20, 10:42 Completed build in 11m 55s on Mon, 26 Oct, 10:42 AM Test Summary: 73559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6883
-
Michael Telgkamp voted on patch set 11 V +1 CR +1 11/06/20, 10:17
-
Oliver Klee voted on patch set 11 CR +1 11/06/20, 11:14
-
Martin Kutschker voted on patch set 11 CR +1 11/09/20, 17:18
-
Torben Hansen voted on patch set 11 CR +1 11/12/20, 18:43
-
Martin Kutschker voted on patch set 11 V +1 11/14/20, 15:28
-
Benni Mack voted on patch set 11 V +2 CR +2 11/20/20, 15:18
-
Benni Mack merged patch set 12 11/20/20, 15:18
-
Benni Mack commented on patch set 12 01/27/21, 10:54
I opt for reverting this change in light of this regression https://forge.typo3.org/issues/93091 -
Michael Telgkamp commented on patch set 12 01/28/21, 08:11
Reply
As the regression is fixed now in https://review.typo3.org/c/Packages/TYPO3.CMS/+/67541 and https://review.typo3.org/c/Packages/TYPO3.CMS/+/67542, this should not be reverted any longer.