Review main Merged

66233[BUGFIX] Use button tag for modal buttons in InlineControlContainer

Olaf Schmidt-Wischhöfer CR +2 V +2 Normal +37 −40 updated 01/28/21, 08:11

Commit message

Instead of <a href="#" ...> or <span ...>, a <button> tag is used for
inline relations to enable proper keyboard navigation.

* rename variable and protected method names from "link" to "button"
* remove unsed $objectPrefix argument from getLevelInteractionLink
  (now ...Button)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Martin Kutschker +1
    • Torben Hansen +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benni Mack +2
    • Martin Kutschker +1
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 3849

Show 1824 earlier messages
  1. Olaf Schmidt-Wischhöfer uploaded patch set 1 10/21/20, 13:12

  2. Georg Ringer updated the commit message in patch set 2 10/21/20, 13:15

  3. Georg Ringer wrote 10/21/20, 13:16

    Topic set to a11y
  4. TYPO3com voted on patch set 1 V +1 10/21/20, 13:37 Completed build in 23m 44s on Wed, 21 Oct, 01:37 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6736

  5. TYPO3com voted on patch set 2 V +1 10/21/20, 13:41 Completed build in 16m 45s on Wed, 21 Oct, 01:41 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6737

  6. Georg Ringer voted on patch set 2 V +1 CR +1 10/21/20, 20:06

  7. Oli Bartsch commented on patch set 2 V -1 10/21/20, 21:35

    Hi, thanks for your contribution. I had a look at your patch and there seems to be a problem with the "add online media button" now (independent of the missing closing tag). What I did: * Go into page properties (Tab Resources) * Click "Create new relation" and add a media file * Click "Select & Upload files" and upload a media file * Click "Add media by Url" => Here now the whole FormEngine reloads and the previously added media files are gone. Furthermore after inserting a url, it can not be added as the "Add media" button does not react. Could you please have a look at this? And just an idea. What do you think about also fixing the a-tags in InlineRecordContainer?

    InlineControlContainer.php:456 Unresolved

    Here we should also ensure no <a href="#"> tags are generated.

    InlineControlContainer.php:582

    Must also be </button> then.
  8. Olaf Schmidt-Wischhöfer uploaded patch set 3 10/22/20, 09:21

  9. TYPO3com voted on patch set 3 V -1 10/22/20, 09:22 Completed build in 20s on Thu, 22 Oct, 09:22 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6779

  10. Olaf Schmidt-Wischhöfer commented on patch set 3 10/22/20, 09:23

    > What I did: > * Go into page properties (Tab Resources) > * Click "Create new relation" and add a media file > * Click "Select & Upload files" and upload a media file > * Click "Add media by Url" => Here now the whole FormEngine reloads and the previously added media files are gone. Furthermore after inserting a url, it can not be added as the "Add media" button does not react. > > Could you please have a look at this? Thank you for your review and test. I have fixed this problem with "Add media by Url". > And just an idea. What do you think about also fixing the a-tags in InlineRecordContainer? I also include the from wrapWithAnchor now.
  11. Olaf Schmidt-Wischhöfer commented on patch set 3 10/22/20, 09:25

    InlineControlContainer.php:582 Reply

    Done
  12. Olaf Schmidt-Wischhöfer uploaded patch set 4 10/22/20, 09:26

  13. TYPO3com voted on patch set 4 V +1 10/22/20, 09:40 Completed build in 13m 44s on Thu, 22 Oct, 09:40 AM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6780

  14. Olaf Schmidt-Wischhöfer uploaded patch set 5 10/22/20, 09:42

  15. Oliver Klee commented on patch set 5 CR -1 10/22/20, 09:46

    InlineControlContainer.php:545

    We also need to add type="button" to all those new buttons so that they do not work as submit buttons (which is the default behavior, see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button ).
  16. Oli Bartsch commented on patch set 5 V -1 10/22/20, 09:51

    There seems to be no change in the code (comparing https://review.typo3.org/c/Packages/TYPO3.CMS/+/66233/2..5)
  17. Olaf Schmidt-Wischhöfer uploaded patch set 6 10/22/20, 09:57

  18. Olaf Schmidt-Wischhöfer commented on patch set 6 10/22/20, 09:58

    > There seems to be no change in the code (comparing https://review.typo3.org/c/Packages/TYPO3.CMS/+/66233/2..5) Yes, I used the wrong patch set when rebasing onto current master. Sorry. I have redone this now.
  19. TYPO3com voted on patch set 5 V +1 10/22/20, 10:03 Completed build in 21m 16s on Thu, 22 Oct, 10:03 AM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6782

  20. TYPO3com voted on patch set 6 V +1 10/22/20, 10:11 Completed build in 13m 56s on Thu, 22 Oct, 10:11 AM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6783

  21. Olaf Schmidt-Wischhöfer commented on patch set 6 10/22/20, 13:09

    > Patch Set 5: Code-Review-1 > > (1 comment)

    InlineControlContainer.php:545 Reply

    Done
  22. Oliver Klee commented on patch set 6 CR -1 10/22/20, 13:34

    InlineControlContainer.php:456

    I find the change confusing as the method now wraps with either an anchor or a button. I propose we use two different methods now - one for anchors and one for buttons.
  23. Olaf Schmidt-Wischhöfer uploaded patch set 7 10/22/20, 13:54

  24. Oliver Klee commented on patch set 7 10/22/20, 13:56

    InlineControlContainer.php:455

    There's the preposition missing: wrapButton -> wrapWithButton (or wrapInButton) Please also use type declarations for the parameters.
  1. Olaf Schmidt-Wischhöfer uploaded patch set 8 10/22/20, 13:57

  2. Olaf Schmidt-Wischhöfer uploaded patch set 9 10/22/20, 14:01

  3. Olaf Schmidt-Wischhöfer commented on patch set 9 10/22/20, 14:02

    InlineControlContainer.php:455 Reply

    Done

    InlineControlContainer.php:456 Reply Unresolved

    OK, I have added a new method wrapWithButton. But wrapWithAnchor seems unused now – unless there is a sub-class somewhere using it. Should I remove the method?
  4. TYPO3com voted on patch set 7 V -1 10/22/20, 14:10 Completed build in 15m 45s on Thu, 22 Oct, 02:10 PM Test Summary: 73034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6798

  5. TYPO3com voted on patch set 8 V +1 10/22/20, 14:15 Completed build in 18m 24s on Thu, 22 Oct, 02:15 PM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6799

  6. TYPO3com voted on patch set 9 V +1 10/22/20, 14:21 Completed build in 16m 57s on Thu, 22 Oct, 02:21 PM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6801

  7. Michael Telgkamp commented on patch set 9 CR -1 10/22/20, 21:11

    The variable names and the comments should reflect the change from links to buttons as well.

    InlineControlContainer.php:399

    I would suggest to also change the description and use `button` here instead of `link`

    InlineControlContainer.php:401

    also the function name should represent the change and be renamed to getLevelInteractionButton

    InlineControlContainer.php:444

    I would suggest to rename the variable from $link to $button (also in the comment)

    InlineControlContainer.php:479

    The html generated is an HTML button now
  8. Olaf Schmidt-Wischhöfer uploaded patch set 10 10/23/20, 07:24

  9. Olaf Schmidt-Wischhöfer commented on patch set 10 10/23/20, 07:26

    InlineControlContainer.php:399 Reply

    Done

    InlineControlContainer.php:401 Reply

    Done

    InlineControlContainer.php:444 Reply

    Done

    InlineControlContainer.php:479 Reply

    Done
  10. TYPO3com voted on patch set 10 V +1 10/23/20, 07:36 Completed build in 11m 34s on Fri, 23 Oct, 07:36 AM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6817

  11. Oliver Klee voted on patch set 10 CR +1 10/23/20, 07:42

  12. Martin Kutschker voted on patch set 10 CR +1 10/25/20, 17:29

  13. Oli Bartsch commented on patch set 10 CR -1 10/26/20, 10:15

  14. Olaf Schmidt-Wischhöfer updated the commit message in patch set 11 10/26/20, 10:30

  15. Olaf Schmidt-Wischhöfer commented on patch set 11 10/26/20, 10:35

  16. TYPO3com voted on patch set 11 V +1 10/26/20, 10:42 Completed build in 11m 55s on Mon, 26 Oct, 10:42 AM Test Summary: 73559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6883

  17. Michael Telgkamp voted on patch set 11 V +1 CR +1 11/06/20, 10:17

  18. Oliver Klee voted on patch set 11 CR +1 11/06/20, 11:14

  19. Martin Kutschker voted on patch set 11 CR +1 11/09/20, 17:18

  20. Torben Hansen voted on patch set 11 CR +1 11/12/20, 18:43

  21. Martin Kutschker voted on patch set 11 V +1 11/14/20, 15:28

  22. Benni Mack voted on patch set 11 V +2 CR +2 11/20/20, 15:18

  23. Benni Mack merged patch set 12 11/20/20, 15:18

  24. Benni Mack commented on patch set 12 01/27/21, 10:54

    I opt for reverting this change in light of this regression https://forge.typo3.org/issues/93091
  25. Michael Telgkamp commented on patch set 12 01/28/21, 08:11

    Reply

    As the regression is fixed now in https://review.typo3.org/c/Packages/TYPO3.CMS/+/67541 and https://review.typo3.org/c/Packages/TYPO3.CMS/+/67542, this should not be reverted any longer.