Review main Merged

66235[TASK] Provide title attribute for iframes

Oli Bartsch CR +2 V +2 Easy +20 −5 updated 10/21/20, 16:05

Commit message

All iframes must contain a description to allow screen
readers to identify the content or purpose of them.

Therefore all iframes are now equipped with a proper
title attribute, describing their content.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 911

  1. Oli Bartsch uploaded patch set 1 10/21/20, 14:07

  2. Oli Bartsch wrote 10/21/20, 14:07

    Topic set to a11y
  3. TYPO3com voted on patch set 1 V +1 10/21/20, 14:19 Completed build in 12m 31s on Wed, 21 Oct, 02:19 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6740

  4. Josef Glatz commented on patch set 1 10/21/20, 14:33

    locallang.xlf:348

    intended to have no "the" inside this key in direct comparison to iframe.livePreview
  5. Oli Bartsch commented on patch set 2 10/21/20, 14:58

    Published edit on patch set 1.
  6. Oli Bartsch commented on patch set 2 10/21/20, 14:58

    locallang.xlf:348 Reply

    Done
  7. TYPO3com voted on patch set 2 V +1 10/21/20, 15:11 Completed build in 12m 32s on Wed, 21 Oct, 03:11 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6743

  8. Georg Ringer voted on patch set 2 V +1 CR +1 10/21/20, 15:31

  9. Josef Glatz voted on patch set 2 V +1 CR +1 10/21/20, 16:01

  10. Daniel Goerz voted on patch set 2 V +2 CR +2 10/21/20, 16:04

  11. Daniel Goerz merged patch set 3 10/21/20, 16:05