Review main Abandoned

66236[BUGFIX] Add aria role="alert" to character counter

Georg Ringer CR 0 V 0 Easy +1 −1 updated 10/19/21, 18:55

Commit message

Improve the accessibility of the character counter below an FormEngine
field by setting the attribute role to 'alert'.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 67

  1. Georg Ringer uploaded patch set 1 10/21/20, 14:20

  2. Georg Ringer commented on patch set 1 10/21/20, 14:20

    This change is ready for review.
  3. Georg Ringer wrote 10/21/20, 14:21

    Topic set to a11y
  4. TYPO3com voted on patch set 1 V +1 10/21/20, 14:34 Completed build in 13m 43s on Wed, 21 Oct, 02:34 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6741

  5. Daniel Haupt commented on patch set 1 CR -1 10/22/20, 15:26

    FormEngine.js:464

    "Because of its intrusive nature, the alert role must be used sparingly and only in situations where the user's immediate attention is required."(https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_alert_role). I guess this immediate attention is only relevant e.g. in case remaining characters are zero. We could use role="status" instead and/or add role="alert" only when no more characters are possible.
  6. Martin Kutschker commented on patch set 1 CR -1 11/07/20, 21:53

    FormEngine.js:464 Reply Unresolved

    At best the number of remaining characters can be presented with the role "status". Even this could be too intrusive. Maybe it is nice to have the status be enabled when only 10 or less characters are remaining. But I'd go and seek advice of actual screen reader users. https://www.w3.org/TR/wai-aria/#status
  7. Georg Ringer abandoned the change 10/19/21, 18:55

    abandoned, no interest