Review main Merged

66237[TASK] Use correct html element for actions in RecordList

Georg Ringer CR +2 V +2 Hard +188 −123 updated 06/21/21, 12:48

Commit message

Differentiate between tags 'a' and 'button' in the record list.
An a-tag opens a page, a button triggers an action.

Additionally the change includes 3 accessibility related issues:

Implement browser "tooltips" (ie title attributes) on a-tags
and button-tags as Bootstrap tooltips.

Add aria-haspopup="dialog" on buttons that open a Bootstrap modal
which are implemented as ARIA role dialog.

Remove attribute role="group" from elements without accessible name.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 3251

Show 1626 earlier messages
  1. Georg Ringer uploaded patch set 1 10/21/20, 15:34

  2. Georg Ringer commented on patch set 1 10/21/20, 15:35

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 10/21/20, 15:47 Completed build in 13m 01s on Wed, 21 Oct, 03:47 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6744

  4. Daniel Haupt uploaded patch set 2 10/22/20, 22:31

  5. TYPO3com voted on patch set 2 V +1 10/22/20, 22:46 Completed build in 15m 13s on Thu, 22 Oct, 10:46 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6815

  6. Oli Bartsch commented on patch set 2 CR -1 10/23/20, 07:11

    As all buttons are referring to the outer form[name=dblistForm] they must have set the type=button attribute to not being falsely treated as submit buttons (even if the event is prevented by JavaScript in that case).
  7. Martin Kutschker commented on patch set 2 12/08/20, 19:39

    Simply applying role button to an a tag is not enough. You must add a handler that triggers the button action on space and enter (keydown to work properly with screen readers). Didn't test the patch now, but there are two occurences to watch out.
  8. Andreas Kienast commented on patch set 2 CR -1 12/12/20, 16:23

    Modal.ts:385

    data-data-uri="foobar"? This looks wrong, I assume this must be `$element.attr('data-uri')`.
  9. Martin Kutschker commented on patch set 2 CR -1 12/13/20, 19:57

    Unresolved

    The buttons have no accessible names. The buttons have unlike a-tags not BS tooltips. If I manually add them with data-toogle="tooltip" they show-up on keyboard focus unlike a-tag tooltips which automagically appear only on mouse hover. The manual activation with the data attribute is actually better, but both ways suffer from the fact that in the use case of TYPO3 the tooltip duplicates the accessible name provided with aria-describedby.
  10. Martin Kutschker uploaded patch set 3 12/18/20, 21:14

  11. TYPO3com voted on patch set 3 V -1 12/18/20, 21:14 Completed build in 26s on Fri, 18 Dec, 09:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8274

  12. Martin Kutschker uploaded patch set 4 12/22/20, 19:40

  13. TYPO3com voted on patch set 4 V -1 12/22/20, 19:41 Completed build in 21s on Tue, 22 Dec, 07:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8443

  14. Martin Kutschker uploaded patch set 5 12/22/20, 19:46

  15. TYPO3com voted on patch set 5 V -1 12/22/20, 19:55 Completed build in 09m 38s on Tue, 22 Dec, 07:55 PM Test Summary: 88 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8444

  16. TYPO3com commented on patch set 5 12/25/20, 12:55 Completed build in 09m 43s on Fri, 25 Dec, 12:55 PM Test Summary: 88 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8461

  17. Martin Kutschker uploaded patch set 6 12/27/20, 09:42

  18. TYPO3com voted on patch set 6 V +1 12/27/20, 09:51 Completed build in 09m 26s on Sun, 27 Dec, 09:51 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8463

  19. Martin Kutschker commented on patch set 6 01/08/21, 09:39

    Modal.ts:385 Reply

    Done
  20. Martin Kutschker uploaded patch set 7 01/25/21, 18:41

  21. TYPO3com voted on patch set 7 V -1 01/25/21, 18:41 Completed build in 21s on Mon, 25 Jan, 06:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9046

  22. TYPO3com commented on patch set 7 01/25/21, 19:36 Completed build in 55m 00s on Mon, 25 Jan, 07:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9046

  23. Michael Telgkamp uploaded patch set 8 01/26/21, 07:39

  24. TYPO3com voted on patch set 8 V +1 01/26/21, 07:49 Completed build in 10m 24s on Tue, 26 Jan, 07:49 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9051

  25. Martin Kutschker commented on patch set 8 CR -1 01/26/21, 08:32

    Noticed a few missing #-links. Update is on the way.
  26. Martin Kutschker uploaded patch set 9 01/31/21, 15:42

  1. TYPO3com voted on patch set 9 V -1 01/31/21, 15:53 Completed build in 10m 37s on Sun, 31 Jan, 03:53 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9117

  2. TYPO3com voted on patch set 9 V +1 01/31/21, 16:25 Completed build in 10m 39s on Sun, 31 Jan, 04:25 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9118

  3. Martin Kutschker uploaded patch set 10 03/05/21, 14:33

  4. TYPO3com voted on patch set 10 V +1 03/05/21, 14:40 Completed build in 06m 58s on Fri, 5 Mar, 02:40 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9870

  5. core-ci voted on patch set 10 V +1 03/05/21, 14:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1203

  6. Martin Kutschker uploaded patch set 11 03/30/21, 19:55

  7. TYPO3com voted on patch set 11 V +1 03/30/21, 20:01 Completed build in 05m 28s on Tue, 30 Mar, 08:01 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10398

  8. core-ci voted on patch set 11 V +1 03/30/21, 20:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1918

  9. Benni Mack uploaded patch set 12 04/14/21, 15:37

  10. TYPO3com voted on patch set 12 V +1 04/14/21, 15:44 Completed build in 06m 49s on Wed, 14 Apr, 03:44 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10663

  11. core-ci voted on patch set 12 V +1 04/14/21, 15:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2248

  12. Martin Kutschker voted on patch set 12 V +1 04/23/21, 08:41

  13. Benni Mack commented on patch set 12 04/23/21, 09:03

    there are still a few @todos in there, are they kept in there @masi?
  14. Martin Kutschker commented on patch set 12 04/23/21, 12:20

    Reply Unresolved

    @todo separate table header from contract/expand link This one is would make the commit larger and involes a bigger rework. We can keep it or remove it ... and wait for a big redesign :) The other two are slips. I don't recall why I didn't do what's required to remove the note.
  15. Benni Mack voted on patch set 12 V +1 CR +1 05/01/21, 12:03

  16. Andreas Kienast commented on patch set 12 V -1 05/02/21, 10:34

    Copyring a record from clipboard after another element doesn't work anymore. AFAICS the paste action is never executed.
  17. Andreas Kienast commented on patch set 12 05/02/21, 10:45

    After clearing all caches it got even worse, the modal shows a spinner only, the underlyting AJAX call abort with an exception: Argument 2 passed to TYPO3\CMS\Core\DataHandling\Localization\DataMapProcessor::collectItems() must be of the type array, string given, called in typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php on line 141
  18. Andreas Kienast uploaded patch set 13 05/02/21, 11:01

  19. Andreas Kienast voted on patch set 13 V +1 CR +1 05/02/21, 11:02

  20. core-ci voted on patch set 13 V +1 05/02/21, 11:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11034

  21. Benni Mack voted on patch set 13 V +2 CR +2 05/03/21, 08:01

  22. Benni Mack merged patch set 14 05/03/21, 08:01

  23. Benni Mack commented on patch set 14 05/03/21, 08:30

    DatabaseRecordList.php:2779 Unresolved

    argh, I missed that one now! Will come up with a
  24. Benni Mack commented on patch set 14 05/03/21, 08:31

  25. Oli Bartsch commented on patch set 14 06/21/21, 12:48

    DatabaseRecordList.php:1197 Unresolved