Review main Merged

66238[BUGFIX] Make paste content button accessible via keyboard

Oli Bartsch CR +2 V +2 Easy +4 −4 updated 10/21/20, 19:43

Commit message

The paste content button in the page module was not
accessible via the keyboard because of it being an anchor
element without a `href` attribute (so no tabstop).

The button is therefore now changed to use a button
tag, allowing it to be accessed via the keyboard.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Daniel Haupt +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1114

  1. Oli Bartsch uploaded patch set 1 10/21/20, 15:45

  2. Oli Bartsch wrote 10/21/20, 15:46

    Topic set to a11y
  3. TYPO3com voted on patch set 1 V +1 10/21/20, 15:57 Completed build in 11m 22s on Wed, 21 Oct, 03:57 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6745

  4. Josef Glatz updated the commit message in patch set 2 10/21/20, 16:04

  5. Georg Ringer voted on patch set 2 V +1 CR +1 10/21/20, 16:09

  6. TYPO3com voted on patch set 2 V +1 10/21/20, 16:21 Completed build in 15m 16s on Wed, 21 Oct, 04:21 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6748

  7. Daniel Haupt voted on patch set 2 V +1 CR +1 10/21/20, 16:43

  8. Wouter Wolters commented on patch set 2 10/21/20, 17:28

    Unresolved

    The paste content
  9. Daniel Goerz updated the commit message in patch set 3 10/21/20, 17:35

  10. Daniel Goerz voted on patch set 3 CR +1 10/21/20, 17:41

  11. Daniel Haupt voted on patch set 3 V +1 CR +1 10/21/20, 17:41

  12. TYPO3com voted on patch set 3 V +1 10/21/20, 17:56 Completed build in 20m 11s on Wed, 21 Oct, 05:56 PM Test Summary: 73486 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6758

  13. Georg Ringer voted on patch set 3 V +2 CR +2 10/21/20, 19:43

  14. Georg Ringer merged patch set 4 10/21/20, 19:43