Review main Merged

6624[BUGFIX] Validation for multiple forms on one page

Niki Mueller CR +2 V +2 Normal +32 −19 updated 06/03/13, 20:49

Commit message

Since the class tx_form_System_Validate is a singleton, it was not
possible to use more than one form on a page. This patch changes
the arrays $rules, $messages and $errors, using the current form-
prefix as key, allowing for validation of several different forms
on one page.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Frederic Gaus +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Frederic Gaus +1
    • Philipp Gampe +1

Files 1

Review log 34

Show 9 earlier messages
  1. Philipp Gampe commented on patch set 2 02/09/12, 00:18

    I tried to test this one, but http://forge.typo3.org/issues/31778 got in my way. I guess it is not directly related, but it prevends (at least me) from testing.
  2. Andreas Bouche commented on patch set 2 02/09/12, 00:18

    Looks good to me, but someone else must approve
  3. Niki Mueller uploaded patch set 2 02/09/12, 00:18

  4. Georg Ringer commented on patch set 3 02/09/12, 00:18

    (1 inline comment)
  5. Niki Mueller uploaded patch set 3 02/09/12, 00:18

  6. Stefan Neufeind commented on patch set 4 02/09/12, 00:18

    Looks good to me, but someone else must approve
  7. Stefan Neufeind commented on patch set 4 02/09/12, 00:18

    (1 inline comment) @Xavier: don't think caching prefix would be that easy
  8. Tolleiv Nietsch uploaded patch set 6 02/09/12, 00:18

  9. Tolleiv Nietsch uploaded patch set 7 02/09/12, 00:18

  1. Tolleiv Nietsch commented on patch set 7 02/09/12, 00:18

    Verified; Looks good to me, but someone else must approve I agree with Oliver Klee - at least in addRule() and isValid() the prefix should be kept in a local variable. Makes it a but less ugly. Besides that the change worked fine form me.
  2. Tolleiv Nietsch commented on patch set 7 V 0 02/09/12, 00:18

    by team member; Looks good to me, approved
  3. Stefan Neufeind commented on patch set 5 02/09/12, 00:18

    Looks good to me, but someone else must approve
  4. Oliver Klee commented on patch set 5 02/09/12, 00:18

    (3 inline comments)
  5. Oliver Hader commented on patch set 5 02/09/12, 00:18

    Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:0, R:1 from Georg Ringer <mail@ringerge.org> V:0, R:1 from Andreas Bouche <bouche@flagbit.de> V:1, R:1 from Frederic Gaus <gaus@flagbit.de> V:0, R:1 from Cedric Ziel <cedric@cedric-ziel.com>
  6. Oliver Hader uploaded patch set 5 02/09/12, 00:18

  7. Xavier Perseguers commented on patch set 4 02/09/12, 00:18

    (1 inline comment)
  8. Georg Ringer commented on patch set 4 02/09/12, 00:18

    Looks good to me, but someone else must approve
  9. Philipp Gampe commented on patch set 7 02/09/12, 00:18

    Verified; Looks good to me, but someone else must approve I can not reproduce this bug as it works for me (two forms with on field each - one an email field and the second a digit field). I can sent both form without a problem no matter whether this patch is applied or not. Anyway does not break things.
  10. Philipp Gampe commented on patch set 7 02/09/12, 00:18

    @Frederic Thanks, that was the missing piece.
  11. Andreas Bouche commented on patch set 4 02/09/12, 00:18

    Looks good to me, but someone else must approve
  12. Niki Mueller uploaded patch set 4 02/09/12, 00:18

  13. Frederic Gaus commented on patch set 2 02/09/12, 00:18

    Verified; I would prefer that you didn't submit this The patch is working well. But the getRules() function is not needed to be implemented in this context. So this is not a clean patch. See comments in code

    Validate.php:120

    This function is not needed for this patchset.
  14. Frederic Gaus commented on patch set 4 02/09/12, 00:18

    Verified; Looks good to me, but someone else must approve
  15. Frederic Gaus commented on patch set 5 02/09/12, 00:18

    Verified; Looks good to me, but someone else must approve
  16. Frederic Gaus commented on patch set 7 02/09/12, 00:18

    Verified; Looks good to me, but someone else must approve @Philipp Gampe: Make sure that your form fields are marked as being required. Otherwise it won't break the functionallity.
  17. Cedric Ziel commented on patch set 4 02/09/12, 00:18

    Looks good to me, but someone else must approve
  18. Mr. Jenkins commented on patch set 1 02/09/12, 00:18

  19. Mr. Jenkins commented on patch set 2 02/09/12, 00:18

  20. Mr. Jenkins commented on patch set 3 02/09/12, 00:18

  21. Mr. Jenkins commented on patch set 4 02/09/12, 00:18

  22. Mr. Jenkins commented on patch set 5 02/09/12, 00:18

  23. Mr. Jenkins commented on patch set 6 02/09/12, 00:18

  24. Mr. Jenkins commented on patch set 7 02/09/12, 00:18

  25. Tolleiv Nietsch merged patch set 7 02/09/12, 00:18