6624[BUGFIX] Validation for multiple forms on one page
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Frederic Gaus +1
- Philipp Gampe +1
-
Verified V +2
- Tolleiv Nietsch +2
- Frederic Gaus +1
- Philipp Gampe +1
Files 1
Review log 34
Show 9 earlier messages
-
Philipp Gampe commented on patch set 2 02/09/12, 00:18
I tried to test this one, but http://forge.typo3.org/issues/31778 got in my way. I guess it is not directly related, but it prevends (at least me) from testing. -
Andreas Bouche commented on patch set 2 02/09/12, 00:18
Looks good to me, but someone else must approve -
Niki Mueller uploaded patch set 2 02/09/12, 00:18
-
Georg Ringer commented on patch set 3 02/09/12, 00:18
(1 inline comment) -
Niki Mueller uploaded patch set 3 02/09/12, 00:18
-
Stefan Neufeind commented on patch set 4 02/09/12, 00:18
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 4 02/09/12, 00:18
(1 inline comment) @Xavier: don't think caching prefix would be that easy -
Tolleiv Nietsch uploaded patch set 6 02/09/12, 00:18
-
Tolleiv Nietsch uploaded patch set 7 02/09/12, 00:18
-
Tolleiv Nietsch commented on patch set 7 02/09/12, 00:18
Verified; Looks good to me, but someone else must approve I agree with Oliver Klee - at least in addRule() and isValid() the prefix should be kept in a local variable. Makes it a but less ugly. Besides that the change worked fine form me. -
Tolleiv Nietsch commented on patch set 7 V 0 02/09/12, 00:18
by team member; Looks good to me, approved -
Stefan Neufeind commented on patch set 5 02/09/12, 00:18
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 5 02/09/12, 00:18
(3 inline comments) -
Oliver Hader commented on patch set 5 02/09/12, 00:18
Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:0, R:1 from Georg Ringer <mail@ringerge.org> V:0, R:1 from Andreas Bouche <bouche@flagbit.de> V:1, R:1 from Frederic Gaus <gaus@flagbit.de> V:0, R:1 from Cedric Ziel <cedric@cedric-ziel.com> -
Oliver Hader uploaded patch set 5 02/09/12, 00:18
-
Xavier Perseguers commented on patch set 4 02/09/12, 00:18
(1 inline comment) -
Georg Ringer commented on patch set 4 02/09/12, 00:18
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 7 02/09/12, 00:18
Verified; Looks good to me, but someone else must approve I can not reproduce this bug as it works for me (two forms with on field each - one an email field and the second a digit field). I can sent both form without a problem no matter whether this patch is applied or not. Anyway does not break things. -
Philipp Gampe commented on patch set 7 02/09/12, 00:18
@Frederic Thanks, that was the missing piece. -
Andreas Bouche commented on patch set 4 02/09/12, 00:18
Looks good to me, but someone else must approve -
Niki Mueller uploaded patch set 4 02/09/12, 00:18
-
Frederic Gaus commented on patch set 2 02/09/12, 00:18
Verified; I would prefer that you didn't submit this The patch is working well. But the getRules() function is not needed to be implemented in this context. So this is not a clean patch. See comments in codeValidate.php:120This function is not needed for this patchset. -
Frederic Gaus commented on patch set 4 02/09/12, 00:18
Verified; Looks good to me, but someone else must approve -
Frederic Gaus commented on patch set 5 02/09/12, 00:18
Verified; Looks good to me, but someone else must approve -
Frederic Gaus commented on patch set 7 02/09/12, 00:18
Verified; Looks good to me, but someone else must approve @Philipp Gampe: Make sure that your form fields are marked as being required. Otherwise it won't break the functionallity. -
Cedric Ziel commented on patch set 4 02/09/12, 00:18
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 02/09/12, 00:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2380/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/09/12, 00:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2381/ : SUCCESS -
Mr. Jenkins commented on patch set 3 02/09/12, 00:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2400/ : SUCCESS -
Mr. Jenkins commented on patch set 4 02/09/12, 00:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2401/ : SUCCESS -
Mr. Jenkins commented on patch set 5 02/09/12, 00:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2661/ : SUCCESS -
Mr. Jenkins commented on patch set 6 02/09/12, 00:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2970/ : SUCCESS -
Mr. Jenkins commented on patch set 7 02/09/12, 00:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2971/ : SUCCESS -
Tolleiv Nietsch merged patch set 7 02/09/12, 00:18