Review main Merged

66240[BUGFIX] Fix label for pages.no_search column

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 10/21/20, 17:31

Commit message

Since the column is using the `invertStateDisplay` the
label must take this into account otherwise the display
in e.g. single-table-view is wrong.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Daniel Haupt +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Oli Bartsch uploaded patch set 1 10/21/20, 16:53

  2. Oli Bartsch wrote 10/21/20, 16:54

    Topic set to a11y
  3. TYPO3com voted on patch set 1 V -1 10/21/20, 17:07 Completed build in 13m 35s on Wed, 21 Oct, 05:07 PM Test Summary: 72410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6754

  4. TYPO3com voted on patch set 1 V +1 10/21/20, 17:24 Completed build in 15m 07s on Wed, 21 Oct, 05:24 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6756

  5. Daniel Haupt commented on patch set 1 V +1 CR +1 10/21/20, 17:26

    The CSH label `no_search.description` should also be updated, right?
  6. Daniel Goerz voted on patch set 1 V +2 CR +2 10/21/20, 17:30

  7. Daniel Goerz merged patch set 2 10/21/20, 17:31