Review main Merged

66242[BUGFIX] Fix PHP type error in f:form.select.optgroup view helper

Oliver Hader CR +2 V +2 Easy +1 −1 updated 10/22/20, 10:11

Commit message

Using view helper `f:form.select.optgroup` with argument `disabled`
throws PHP type error, since array is expected, but string given.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Markus Klein +1
    • Daniel Haupt +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Markus Klein +1
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Oliver Hader uploaded patch set 1 10/21/20, 19:32

  2. TYPO3com voted on patch set 1 V +1 10/21/20, 19:43 Completed build in 11m 18s on Wed, 21 Oct, 07:43 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6760

  3. Daniel Haupt commented on patch set 1 CR -1 10/21/20, 23:58

    FlashMessagesViewHelper.php:111 Unresolved

    Why should this parameter be required from now? This would be a breaking change I guess.
  4. Oliver Hader commented on patch set 1 CR -1 10/22/20, 07:38

    Seems you're right - I cannot reproduce that in my local failing test cases and it seems to be handled in flash messages view helper
  5. Oliver Hader uploaded patch set 2 10/22/20, 07:43

  6. Markus Klein voted on patch set 2 V +1 CR +1 10/22/20, 07:45

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 10/22/20, 07:54

  8. TYPO3com voted on patch set 2 V +1 10/22/20, 08:02 Completed build in 19m 00s on Thu, 22 Oct, 08:02 AM Test Summary: 73486 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6777

  9. Daniel Haupt voted on patch set 2 V +1 CR +1 10/22/20, 09:25

  10. Oliver Klee voted on patch set 2 CR +1 10/22/20, 09:47

  11. Daniel Goerz voted on patch set 2 V +2 CR +2 10/22/20, 10:11

  12. Daniel Goerz merged patch set 3 10/22/20, 10:11