Review main Merged

66243[BUGFIX] Always show edit button to edit page title in page module

Georg Ringer CR +2 V +2 Easy +13 −12 updated 10/28/20, 15:27

Commit message

Always show the edit button so that users know this functionality.
Additionally the element is transformed from an link to an actual
button to be accessible for keyboard users.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Daniel Haupt +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Daniel Haupt +1
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2229

Show 34 earlier messages
  1. Georg Ringer uploaded patch set 1 10/21/20, 20:01

  2. Georg Ringer commented on patch set 1 10/21/20, 20:01

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 10/21/20, 20:13 Completed build in 12m 26s on Wed, 21 Oct, 08:13 PM Test Summary: 1 of 73973 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6762

  4. Oli Bartsch commented on patch set 1 V -1 10/21/20, 21:45

    It's still not possible to access the input field via keyboard. The edit button can be focused with the keyboard now but the page title can not be edited because on pressing the ENTER key (to open the input field) the field is only display for a milliseconds. The reason is that the keyup event registered in editPageTitle() is triggered and therefore directly submits the form. So there is still no possibility to make changes just using the keyboard.
  1. Georg Ringer uploaded patch set 2 10/21/20, 22:23

  2. TYPO3com voted on patch set 2 V -1 10/21/20, 22:35 Completed build in 12m 03s on Wed, 21 Oct, 10:35 PM Test Summary: 1 of 73973 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6771

  3. Georg Ringer uploaded patch set 3 10/21/20, 22:53

  4. TYPO3com voted on patch set 3 V -1 10/21/20, 23:06 Completed build in 12m 44s on Wed, 21 Oct, 11:06 PM Test Summary: 1 of 73973 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6772

  5. Daniel Haupt commented on patch set 3 10/21/20, 23:25

    Tests are passing again when changing the selector in `typo3/sysext/core/Tests/Acceptance/Backend/Page/PageModuleCest.php:75`.
  6. Daniel Haupt uploaded patch set 4 10/22/20, 14:12

  7. TYPO3com voted on patch set 4 V -1 10/22/20, 14:33 Completed build in 15m 13s on Thu, 22 Oct, 02:33 PM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6802

  8. Oli Bartsch commented on patch set 4 10/22/20, 14:43

    Let's remove the unrelated javascript files from this patch.
  9. Daniel Haupt uploaded patch set 5 10/22/20, 14:49

  10. TYPO3com voted on patch set 5 V +1 10/22/20, 15:01 Completed build in 11m 51s on Thu, 22 Oct, 03:01 PM Test Summary: 73491 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6804

  11. Daniel Haupt voted on patch set 5 V +1 CR +1 10/22/20, 15:02

  12. Oli Bartsch commented on patch set 5 V -1 CR -1 10/22/20, 15:45

    Sorry but this is still not working properly. With this patch it's not possible anymore to get to the content area without opening the edit page title input. It now always opens when tabbing through. After the input was opened unintentional by just tabbing the focus is however not on the input but on the save button. When moving on, the input stays open all the time. Furthermore if the input is opened by clicking the edit icon, the focus is also not on the input. I suggest not working around with just registering more events and then circumvent them in some cases with if clauses.
  13. Daniel Haupt wrote 10/22/20, 15:53

    Removed Verified+1 by Daniel Haupt <mail@danielhaupt.de>
  14. Daniel Haupt wrote 10/22/20, 15:53

    Removed Code-Review+1 by Daniel Haupt <mail@danielhaupt.de>
  15. Daniel Haupt uploaded patch set 6 10/22/20, 21:32

  16. TYPO3com voted on patch set 6 V +1 10/22/20, 21:53 Completed build in 21m 22s on Thu, 22 Oct, 09:53 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6814

  17. Oli Bartsch commented on patch set 6 10/23/20, 07:22

    > Patch Set 5: Verified-1 Code-Review-1 > > Sorry but this is still not working properly. > > With this patch it's not possible anymore to get to the content area without opening the edit page title input. It now always opens when tabbing through. After the input was opened unintentional by just tabbing the focus is however not on the input but on the save button. When moving on, the input stays open all the time. > > Furthermore if the input is opened by clicking the edit icon, the focus is also not on the input. > > I suggest not working around with just registering more events and then circumvent them in some cases with if clauses. Still applies for latest patchset. Additionally if you now open the input by pressing enter wenn focusing the edit icon, you are not able to submit the form with enter (only esc is possible then).
  18. Oli Bartsch uploaded patch set 7 10/26/20, 08:53

  19. TYPO3com voted on patch set 7 V +1 10/26/20, 09:06 Completed build in 12m 42s on Mon, 26 Oct, 09:06 AM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6880

  20. Oli Bartsch voted on patch set 7 V +1 CR +1 10/26/20, 09:08

  21. Daniel Haupt voted on patch set 7 V +1 CR +1 10/26/20, 14:17

  22. Michael Telgkamp voted on patch set 7 V +1 CR +1 10/28/20, 14:58

  23. Georg Ringer voted on patch set 7 V +1 CR +1 10/28/20, 15:27

  24. Georg Ringer voted on patch set 7 V +2 CR +2 10/28/20, 15:27

  25. Georg Ringer merged patch set 8 10/28/20, 15:27