Review main Merged

66244[BUGFIX] Make recordlist collapse button accessible

Oli Bartsch CR +2 V +2 Easy +25 −9 updated 10/23/20, 16:10

Commit message

A <button> tag is now being used instead of an <a> tag
as collapsing / expanding the tables is an interaction on the
same page rather than opening a new one (<a> tag had empty
`href` attribute).

The button now also provides a proper aria-label with a
descriptive text and gets the aria-expandend state
initially set.

Furthermore the button now uses common styling to be
directly recognized as such.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Daniel Haupt +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jens Ulrich +1
    • Daniel Haupt +1
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 2632

Show 47 earlier messages
  1. Oli Bartsch uploaded patch set 1 10/21/20, 20:41

  2. Oli Bartsch uploaded patch set 2 10/21/20, 20:51

  3. TYPO3com voted on patch set 1 V -1 10/21/20, 20:56 Completed build in 14m 21s on Wed, 21 Oct, 08:56 PM Test Summary: 2 of 73973 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6764

  4. Oli Bartsch uploaded patch set 3 10/21/20, 21:04

  5. TYPO3com voted on patch set 2 V -1 10/21/20, 21:13 Completed build in 20m 52s on Wed, 21 Oct, 09:13 PM Test Summary: 2 of 73973 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6766

  6. TYPO3com voted on patch set 3 V +1 10/21/20, 21:18 Completed build in 14m 03s on Wed, 21 Oct, 09:18 PM Test Summary: 73486 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6767

  7. Georg Ringer voted on patch set 3 V +1 CR +1 10/21/20, 21:37

  1. Oli Bartsch wrote 10/21/20, 21:47

    Topic set to a11y
  2. Daniel Haupt commented on patch set 3 V +1 10/21/20, 23:44

    Almost all buttons in the backend have a title (tooltip). I think we should stay consistent here. What do you think? Otherwise the changes are fine!
  3. Michael Telgkamp commented on patch set 3 V -1 CR -1 10/22/20, 06:31

    As the button toggles the expanded state of the list, it should also directly contain the `aria-expanded` status. When using the button this aria attribute is added, but only via Javascript. Note: It is important to use the correct state (lists might be collapsed on load e.g. for list views) so it is not sufficient to add `aria-expanded="true"`. More information on aria-expanded: https://www.w3.org/TR/wai-aria-1.1/#aria-expanded
  4. Oli Bartsch uploaded patch set 4 10/22/20, 07:34

  5. Oli Bartsch commented on patch set 4 10/22/20, 07:35

    > Patch Set 3: Verified-1 Code-Review-1 > > As the button toggles the expanded state of the list, it should also directly contain the `aria-expanded` status. When using the button this aria attribute is added, but only via Javascript. > Note: It is important to use the correct state (lists might be collapsed on load e.g. for list views) so it is not sufficient to add `aria-expanded="true"`. > > More information on aria-expanded: https://www.w3.org/TR/wai-aria-1.1/#aria-expanded Thanks for your feedback. The state will now be initially set.
  6. TYPO3com voted on patch set 4 V +1 10/22/20, 07:47 Completed build in 12m 53s on Thu, 22 Oct, 07:47 AM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6776

  7. Michael Telgkamp commented on patch set 4 CR -1 10/22/20, 07:47

    Just a minor typo.

    DatabaseRecordList.php:867

    There is a double quote missing . ' aria-expanded="' .
  8. Oli Bartsch uploaded patch set 5 10/22/20, 07:49

  9. Oli Bartsch commented on patch set 5 10/22/20, 07:49

    DatabaseRecordList.php:867 Reply

    Done
  10. Michael Telgkamp commented on patch set 5 V +1 CR +1 10/22/20, 08:06

    Looks good to me and works as expected, tested with Chrome+NVDA.
  11. TYPO3com voted on patch set 5 V +1 10/22/20, 08:06 Completed build in 13m 32s on Thu, 22 Oct, 08:06 AM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6778

  12. Georg Ringer voted on patch set 5 V +1 CR +1 10/22/20, 08:39

  13. Oli Bartsch uploaded patch set 6 10/22/20, 09:57

  14. TYPO3com voted on patch set 6 V +1 10/22/20, 10:14 Completed build in 17m 30s on Thu, 22 Oct, 10:14 AM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6784

  15. Michael Telgkamp voted on patch set 6 V +1 CR +1 10/22/20, 20:51

  16. Daniel Haupt voted on patch set 6 V +1 CR +1 10/22/20, 21:40

  17. Jens Ulrich voted on patch set 6 V +1 10/23/20, 08:12

  18. Oliver Klee commented on patch set 6 CR -1 10/23/20, 09:54

    DatabaseRecordList.php:869

    Shouldn't the htmlspecialchars be around the sprintf so as to also encode the table title?
  19. Oli Bartsch commented on patch set 6 10/23/20, 10:19

    DatabaseRecordList.php:869 Reply

    hsc is already applied to $tableTitle in L:843
  20. Oliver Klee commented on patch set 6 10/23/20, 10:22

    DatabaseRecordList.php:869 Reply

    Oh, thanks. Should we remove it there and switch the calls here? Otherwise, the next reader might stumble on the same issue.
  21. Oli Bartsch commented on patch set 6 10/23/20, 10:25

    DatabaseRecordList.php:869 Reply Unresolved

    It's used at multiple places so would IMO not make sense to remove it from the initial declaration and then apply hsc multiple times at different places (sounds really error-prone).
  22. Oli Bartsch commented on patch set 6 10/23/20, 12:40

    > Patch Set 6: Code-Review-1 > Still something blocking this?
  23. Oliver Klee voted on patch set 6 CR 0 10/23/20, 12:55

  24. Daniel Goerz voted on patch set 6 V +2 CR +2 10/23/20, 16:10

  25. Daniel Goerz merged patch set 7 10/23/20, 16:10