Review main Merged

66246[BUGFIX] Remove upper limits of imagewidth & imageheight of tt_content

Georg Ringer CR +2 V +2 Easy +29 −4 updated 10/29/20, 14:11

Commit message

Remove the upper range from the TCA of the fields imagewidth and
imageheight of tt_content. There is no reason to set it to a random
number which might have been high 10 years ago.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benni Mack +2
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1317

  1. Georg Ringer uploaded patch set 1 10/21/20, 21:56

  2. Georg Ringer commented on patch set 1 10/21/20, 21:56

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 10/21/20, 22:09 Completed build in 13m 16s on Wed, 21 Oct, 10:09 PM Test Summary: 1 of 73973 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6769

  4. Benni Mack rebased onto patch set 2 10/29/20, 09:55

  5. Benni Mack updated the commit message in patch set 3 10/29/20, 09:55

  6. TYPO3com voted on patch set 2 V +1 10/29/20, 10:07 Completed build in 12m 01s on Thu, 29 Oct, 10:07 AM Test Summary: 73554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6987

  7. TYPO3com voted on patch set 3 V +1 10/29/20, 10:12 Completed build in 17m 12s on Thu, 29 Oct, 10:12 AM Test Summary: 73554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6988

  8. Oliver Klee voted on patch set 3 CR +1 10/29/20, 10:23

  9. Michael Telgkamp voted on patch set 3 V +1 CR +1 10/29/20, 10:42

  10. Benni Mack commented on patch set 4 10/29/20, 10:43

    Published edit on patch set 3.
  11. Michael Telgkamp voted on patch set 4 V +1 CR +1 10/29/20, 10:45

  12. TYPO3com voted on patch set 4 V +1 10/29/20, 11:02 Completed build in 15m 03s on Thu, 29 Oct, 11:02 AM Test Summary: 73554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6994

  13. Oliver Klee voted on patch set 4 CR +1 10/29/20, 12:36

  14. Benni Mack voted on patch set 4 V +2 CR +2 10/29/20, 13:24

  15. Benni Mack merged patch set 5 10/29/20, 13:24

  16. Oli Bartsch commented on patch set 5 10/29/20, 13:39

    Post -1, see RST.

    Important-92659-ChangeInTCAOfImagewidthImageheight.rst:18

    That is wrong, `upper => 1999` was removed.

    Important-92659-ChangeInTCAOfImagewidthImageheight.rst:23

    :file:`Configuration/TCA/Overrides.php` .. What is this file?
  17. Michael Telgkamp commented on patch set 5 10/29/20, 14:11

    Important-92659-ChangeInTCAOfImagewidthImageheight.rst:18 Reply Unresolved

    Removed are $GLOBALS['TCA']['tt_content']['columns']['imagewidth']['config']['max'] = 4; $GLOBALS['TCA']['tt_content']['columns']['imagewidth']['config']['range']['upper'] = 1999;

    Important-92659-ChangeInTCAOfImagewidthImageheight.rst:23 Reply Unresolved

    You are right, it should be :file:`Configuration/TCA/Overrides/tt_content.php`.