Review main Merged

66247[FEATURE] Introduce Bootstrap v5 for TYPO3 Backend

Matthias Stegmann CR +2 V +2 Expert +1563 −728 updated 12/20/20, 22:58

Commit message

This changes removes the frontend framework
Bootstrap 3, and adds Bootstrap 5 beta 1 (we
expect Bootstrap 5 final by the time we release TYPO3 v11 LTS).

Bootstrap v3 is not supported by the Bootstrap
team any longer, so an update is critical for TYPO3 Core.

Bootstrap v5 adds a few accessibility improvements
as well as flexbox for rendering
containers and grids throughout TYPO3 Backend.

All JS components are not bound to jQuery anymore,
and have been reworked.

A lot of HTML/CSS changes happened, which we
slowly migrate (and not in a huge change)
to TYPO3's templates, in order to keep
this change managable.

A legacy CSS/SCSS file is added to
keep some backwards-compatibility classes
to ease the migration for extension developers
who have built their own backend modules.

Key features of Bootstrap 5:
* "rem" instead of "px" is used by default
* CSS variables are introduced
* Improved bootstrap focus outline styling (buttons / inputs / links)
* Simplified grid functionality
* use new button color mixin to increase contrast:
  Primary, Success and Warning Button color is now dark instead of white

EXT:styleguide was used as a basis for
upgrading to keep compatibility as much
as possible, but more changes will be coming
in the next few minor releases.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 132

Show 112 more files

Review log 60109

Show 4384 earlier messages
  1. Matthias Stegmann uploaded patch set 1 10/22/20, 07:16

  2. Matthias Stegmann uploaded patch set 2 10/22/20, 07:28

  3. TYPO3com voted on patch set 1 V -1 10/22/20, 07:28 Completed build in 11m 31s on Thu, 22 Oct, 07:28 AM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6774

  4. TYPO3com voted on patch set 2 V -1 10/22/20, 07:39 Completed build in 11m 07s on Thu, 22 Oct, 07:39 AM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6775

  5. Matthias Stegmann uploaded patch set 3 10/22/20, 15:07

  6. TYPO3com voted on patch set 3 V -1 10/22/20, 15:19 Completed build in 12m 42s on Thu, 22 Oct, 03:19 PM Test Summary: 36 of 73943 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6805

  7. Matthias Stegmann rebased onto patch set 4 10/23/20, 06:15

  8. TYPO3com voted on patch set 4 V -1 10/23/20, 06:35 Completed build in 19m 25s on Fri, 23 Oct, 06:35 AM Test Summary: 36 of 73943 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6816

  9. Matthias Stegmann uploaded patch set 5 10/23/20, 09:23

  10. TYPO3com voted on patch set 5 V -1 10/23/20, 09:35 Completed build in 11m 28s on Fri, 23 Oct, 09:35 AM Test Summary: 36 of 73943 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6823

  11. Daniel Sattler uploaded patch set 6 10/27/20, 10:56

  12. TYPO3com voted on patch set 6 V -1 10/27/20, 11:08 Completed build in 11m 59s on Tue, 27 Oct, 11:08 AM Test Summary: 48 of 73932 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6903

  13. Matthias Stegmann uploaded patch set 7 10/27/20, 15:48

  14. TYPO3com voted on patch set 7 V -1 10/27/20, 16:00 Completed build in 11m 40s on Tue, 27 Oct, 04:00 PM Test Summary: 52 of 73930 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6913

  15. Matthias Stegmann uploaded patch set 8 10/27/20, 16:10

  16. TYPO3com voted on patch set 8 V -1 10/27/20, 16:21 Completed build in 11m 04s on Tue, 27 Oct, 04:21 PM Test Summary: 50 of 73927 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6915

  17. Daniel Sattler uploaded patch set 9 10/27/20, 17:09

  18. TYPO3com voted on patch set 9 V -1 10/27/20, 17:21 Completed build in 11m 28s on Tue, 27 Oct, 05:21 PM Test Summary: 54 of 73927 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6925

  19. Daniel Sattler uploaded patch set 10 10/28/20, 10:14

  20. TYPO3com voted on patch set 10 V -1 10/28/20, 10:30 Completed build in 13m 24s on Wed, 28 Oct, 10:29 AM Test Summary: 46 of 73927 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6964

  21. Daniel Sattler uploaded patch set 11 10/28/20, 15:48

  22. TYPO3com voted on patch set 11 V -1 10/28/20, 16:00 Completed build in 11m 29s on Wed, 28 Oct, 04:00 PM Test Summary: 51 of 73927 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6976

  23. Daniel Sattler uploaded patch set 12 10/29/20, 10:34

  24. TYPO3com voted on patch set 12 V -1 10/29/20, 10:47 Completed build in 13m 21s on Thu, 29 Oct, 10:47 AM Test Summary: 48 of 73921 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6991

  25. Daniel Sattler uploaded patch set 13 10/29/20, 16:50

  26. TYPO3com voted on patch set 13 V -1 10/29/20, 17:01 Completed build in 11m 30s on Thu, 29 Oct, 05:01 PM Test Summary: 52 of 73921 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7014

  27. Daniel Sattler uploaded patch set 14 11/03/20, 17:37

  28. TYPO3com voted on patch set 14 V -1 11/03/20, 17:49 Completed build in 12m 03s on Tue, 3 Nov, 05:49 PM Test Summary: 48 of 73936 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7097

  29. Daniel Sattler uploaded patch set 15 11/10/20, 18:10

  30. TYPO3com voted on patch set 15 V -1 11/10/20, 18:11 Completed build in 21s on Tue, 10 Nov, 06:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7232

  31. Daniel Sattler uploaded patch set 16 11/17/20, 16:37

  32. TYPO3com voted on patch set 16 V -1 11/17/20, 16:37 Completed build in 21s on Tue, 17 Nov, 04:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7379

  33. Daniel Haupt uploaded patch set 17 11/30/20, 23:56

  34. TYPO3com voted on patch set 17 V -1 12/01/20, 00:08 Completed build in 11m 31s on Tue, 1 Dec, 12:08 AM Test Summary: 44 of 32527 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7722

  35. Daniel Haupt commented on patch set 17 12/01/20, 02:29

    I just rebased the patch.
  36. Benni Mack uploaded patch set 18 12/12/20, 10:11

  37. TYPO3com voted on patch set 18 V -1 12/12/20, 10:22 Completed build in 10m 23s on Sat, 12 Dec, 10:22 AM Test Summary: 39 of 32534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8110

  38. Benni Mack uploaded patch set 19 12/12/20, 12:33

  39. TYPO3com voted on patch set 19 V -1 12/12/20, 12:44 Completed build in 10m 41s on Sat, 12 Dec, 12:44 PM Test Summary: 44 of 31279 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8114

  40. Benni Mack uploaded patch set 20 12/12/20, 17:10

  41. TYPO3com voted on patch set 20 V -1 12/12/20, 17:20 Completed build in 10m 03s on Sat, 12 Dec, 05:20 PM Test Summary: 56 of 32537 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8125

  42. Oliver Hader commented on patch set 20 12/18/20, 15:03

    InputLinkElement.ts:33

    Seems to be a handler for legacy code, correct? Thus, there could be a comment and also a deprecation message...

    DocHeader.html:12

    Would `col` be enough since each row shall contain max. 2 columns (due to `row-cols-2`)?
  43. Benni Mack commented on patch set 20 12/18/20, 16:30

    InputLinkElement.ts:33 Reply Unresolved

    nope. I had it the other way around, but in general the InputLinkElement HTML code should be streamlined completely (separate task)

    DocHeader.html:12 Reply

    Ack
  44. Benni Mack uploaded patch set 21 12/18/20, 16:42

  45. TYPO3com voted on patch set 21 V -1 12/18/20, 16:50 Completed build in 08m 38s on Fri, 18 Dec, 04:50 PM Test Summary: 45 of 32618 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8258

  46. Benni Mack uploaded patch set 22 12/18/20, 18:55

  47. Benni Mack updated the commit message in patch set 23 12/18/20, 18:57

  48. TYPO3com voted on patch set 22 V -1 12/18/20, 19:06 Completed build in 10m 19s on Fri, 18 Dec, 07:06 PM Test Summary: 38 of 32618 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8265

  49. TYPO3com voted on patch set 23 V -1 12/18/20, 19:11 Completed build in 09m 37s on Fri, 18 Dec, 07:11 PM Test Summary: 46 of 32618 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8266

  50. Oliver Hader uploaded patch set 24 12/18/20, 22:32

  51. TYPO3com voted on patch set 24 V -1 12/18/20, 22:43 Completed build in 11m 26s on Fri, 18 Dec, 10:43 PM Test Summary: 42 of 32618 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8279

  52. Benni Mack uploaded patch set 25 12/18/20, 22:44

  53. TYPO3com voted on patch set 25 V -1 12/18/20, 22:58 Completed build in 11m 13s on Fri, 18 Dec, 10:57 PM Test Summary: 54 of 32618 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8281

  54. Benni Mack uploaded patch set 26 12/18/20, 23:20

  55. TYPO3com voted on patch set 26 V -1 12/18/20, 23:33 Completed build in 12m 21s on Fri, 18 Dec, 11:33 PM Test Summary: 45 of 32618 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8284

  56. Benni Mack uploaded patch set 27 12/18/20, 23:34

  57. TYPO3com voted on patch set 27 V -1 12/18/20, 23:48 Completed build in 11m 00s on Fri, 18 Dec, 11:48 PM Test Summary: 43 of 32618 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8286

  58. Oliver Hader uploaded patch set 28 12/19/20, 10:22

  59. TYPO3com voted on patch set 28 V -1 12/19/20, 10:33 Completed build in 10m 16s on Sat, 19 Dec, 10:33 AM Test Summary: 33 of 32622 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8298

  60. Oliver Hader uploaded patch set 29 12/19/20, 11:07

  61. TYPO3com voted on patch set 29 V -1 12/19/20, 11:21 Completed build in 13m 30s on Sat, 19 Dec, 11:21 AM Test Summary: 8 of 31597 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8302

  62. TYPO3com commented on patch set 29 12/19/20, 11:29 Completed build in 35m 05s on Sat, 19 Dec, 11:29 AM Test Summary: 14 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8302

  63. Oliver Hader uploaded patch set 30 12/19/20, 11:55

  64. TYPO3com voted on patch set 30 V -1 12/19/20, 12:07 Completed build in 12m 25s on Sat, 19 Dec, 12:07 PM Test Summary: 13 of 31638 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8306

  65. Benjamin Franzke commented on patch set 30 12/19/20, 12:15

    DatabaseRecordList.php:989

    class "in" can be dropped with v5. .collapse.in was display:block with bootstrap v3 .collapse:not(.show) is display:none with bootstrap v5 Therefore all occurences of `collapse in` are to be replaced by `collapse show`
  66. TYPO3com commented on patch set 30 12/19/20, 12:18 Completed build in 35m 15s on Sat, 19 Dec, 12:18 PM Test Summary: 12 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8306

  67. TYPO3com commented on patch set 30 12/19/20, 12:27 Completed build in 1h 07m 45s on Sat, 19 Dec, 12:27 PM Test Summary: 12 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8306

  68. Oliver Hader commented on patch set 30 12/19/20, 12:28

    DatabaseRecordList.php:989 Reply Unresolved

    Thx for pointing this out
  69. Oliver Hader uploaded patch set 31 12/19/20, 12:35

  70. TYPO3com voted on patch set 31 V -1 12/19/20, 12:46 Completed build in 10m 35s on Sat, 19 Dec, 12:46 PM Test Summary: 13 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8307

  71. TYPO3com commented on patch set 31 12/19/20, 12:51 Completed build in 26m 14s on Sat, 19 Dec, 12:51 PM Test Summary: 13 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8307

  72. Oliver Hader uploaded patch set 32 12/19/20, 13:06

  73. TYPO3com voted on patch set 32 V -1 12/19/20, 13:16 Completed build in 10m 02s on Sat, 19 Dec, 01:16 PM Test Summary: 7 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8308

  74. Benni Mack uploaded patch set 33 12/19/20, 14:09

  75. Benni Mack uploaded patch set 34 12/19/20, 14:17

  76. TYPO3com voted on patch set 33 V -1 12/19/20, 14:18 Completed build in 08m 58s on Sat, 19 Dec, 02:18 PM Test Summary: 6 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8310

  77. TYPO3com voted on patch set 34 V -1 12/19/20, 14:18 Completed build in 25s on Sat, 19 Dec, 02:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8312

  78. Benni Mack uploaded patch set 35 12/19/20, 14:20

  79. TYPO3com voted on patch set 35 V -1 12/19/20, 14:29 Completed build in 09m 22s on Sat, 19 Dec, 02:29 PM Test Summary: 5 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8313

  80. Benni Mack uploaded patch set 36 12/19/20, 14:50

  81. TYPO3com voted on patch set 36 V -1 12/19/20, 14:59 Completed build in 09m 09s on Sat, 19 Dec, 02:59 PM Test Summary: 6 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8316

  82. TYPO3com commented on patch set 36 12/19/20, 15:16 Completed build in 35m 18s on Sat, 19 Dec, 03:16 PM Test Summary: 6 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8316

  83. Oli Bartsch uploaded patch set 37 12/19/20, 19:02

  84. Benjamin Franzke uploaded patch set 38 12/19/20, 19:05

  1. TYPO3com voted on patch set 37 V -1 12/19/20, 19:12 Completed build in 09m 49s on Sat, 19 Dec, 07:12 PM Test Summary: 6 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8323

  2. TYPO3com voted on patch set 38 V -1 12/19/20, 19:18 Completed build in 09m 32s on Sat, 19 Dec, 07:18 PM Test Summary: 5 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8325

  3. Benjamin Franzke uploaded patch set 39 12/19/20, 19:51

  4. TYPO3com voted on patch set 39 V -1 12/19/20, 20:01 Completed build in 09m 19s on Sat, 19 Dec, 08:01 PM Test Summary: 4 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8326

  5. Benjamin Franzke uploaded patch set 40 12/19/20, 20:01

  6. TYPO3com voted on patch set 40 V -1 12/19/20, 20:10 Completed build in 09m 03s on Sat, 19 Dec, 08:10 PM Test Summary: 3 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8327

  7. Martin Kutschker commented on patch set 40 12/19/20, 20:36

    Note a deal breaker, but the tooltip left-pointing-triangle in the list module("Move this page to the position after the current parent page (Inwards)") flickers over (not above) the icon.
  8. Benjamin Franzke uploaded patch set 41 12/19/20, 20:40

  9. TYPO3com voted on patch set 41 V -1 12/19/20, 20:48 Completed build in 08m 31s on Sat, 19 Dec, 08:48 PM Test Summary: 1 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8328

  10. Benjamin Franzke uploaded patch set 42 12/19/20, 21:00

  11. Martin Kutschker commented on patch set 42 12/19/20, 21:06

    Reply Unresolved

    Happens on Firefox, not on Chrome (Linux). Probably because the tooltip shows two lines of text.
  12. TYPO3com voted on patch set 42 V +1 12/19/20, 21:09 Completed build in 08m 58s on Sat, 19 Dec, 09:09 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8329

  13. Martin Kutschker uploaded patch set 43 12/19/20, 21:41

  14. TYPO3com voted on patch set 43 V +1 12/19/20, 21:50 Completed build in 08m 50s on Sat, 19 Dec, 09:50 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8332

  15. Benni Mack uploaded patch set 44 12/19/20, 23:00

  16. Benni Mack commented on patch set 44 12/19/20, 23:01

    I added all bootstrap utilities (e.g. "mb-3" for "margin-bottom"), also fixed the forms in link popup, and migrated all "col-xs-" to "col-". Also migrated some parts in "visible-sm-block" to "d-sm-blck" in FormEngine
  17. TYPO3com voted on patch set 44 V +1 12/19/20, 23:10 Completed build in 09m 47s on Sat, 19 Dec, 11:10 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8334

  18. Benni Mack commented on patch set 44 V +1 CR +1 12/19/20, 23:14

    I'm sure there are a lot of things to be changed, in all areas: * CSS / SASS (make use of utility classes, migrate to col-form-label) * HTML (reduce usages of form-group, use native flex grid) * JS (migrate to ESM) But continuing on this rather large change makes it hard to work on several parts simultaneously, so I opt for merging this change for now.
  19. Benjamin Franzke commented on patch set 44 V +1 CR +1 12/19/20, 23:25

    also voting +1 given the fact that we need this in and changes for upcoming bootstrap betas will require seaprate patches. Example: all data- tags will need to be renamed to data-bs-*. That will cause massive diff's which need to be handled in seperate patches.
  20. Oliver Hader voted on patch set 44 CR +1 12/20/20, 08:36

  21. Oliver Hader voted on patch set 44 V +1 12/20/20, 09:22

  22. Oli Bartsch voted on patch set 44 V +1 CR +1 12/20/20, 09:34

  23. Benni Mack voted on patch set 44 V +2 CR +2 12/20/20, 10:32

  24. Benni Mack merged patch set 45 12/20/20, 10:32

  25. Felix Kopp commented on patch set 45 12/20/20, 22:58

    Congratulations! So proud of you.