Review main Merged

66248[BUGFIX] Use type "button" for accessible paste content buttons

Oli Bartsch CR +2 V +2 Easy +4 −2 updated 10/25/20, 16:04

Commit message

The paste content buttons now have the type "button" set
to not falsely behave as submit buttons, which is the default
if no type is defined.

See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attr-type

Note: In this case the regular submit event is prevented by
JavaScript which leads to no actual functional change here.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Daniel Haupt +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Oli Bartsch uploaded patch set 1 10/22/20, 10:29

  2. TYPO3com voted on patch set 1 V +1 10/22/20, 10:45 Completed build in 16m 08s on Thu, 22 Oct, 10:45 AM Test Summary: 73494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6787

  3. Daniel Haupt voted on patch set 1 V +1 CR +1 10/22/20, 22:11

  4. Oliver Klee voted on patch set 1 CR +1 10/23/20, 07:44

  5. Oli Bartsch commented on patch set 1 10/23/20, 07:47

    > Patch Set 1: Code-Review+1 Thanks Oliver for pointing that important detail out in the other patch!
  6. Daniel Goerz voted on patch set 1 V +2 CR +2 10/25/20, 16:04

  7. Daniel Goerz merged patch set 2 10/25/20, 16:04