Review main Merged

66258[FEATURE] Make context menu usable via keyboard

Michael Telgkamp CR +2 V +2 Normal +192 −24 updated 12/05/20, 11:41

Commit message

The context menu shows on right click and pressing the context
menu button as well as Shift+F10 where available. Inside the
menu you are able to navigate using the arrow keys, the home
and end keys. Items are activated with ENTER or SPACE key.

Using the ESC key you can hide the current context menu.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 4365

Show 2540 earlier messages
  1. Michael Telgkamp uploaded patch set 1 10/23/20, 09:27

  2. Michael Telgkamp wrote 10/23/20, 09:28

    Topic set to a11y
  3. TYPO3com voted on patch set 1 V -1 10/23/20, 09:40 Completed build in 12m 50s on Fri, 23 Oct, 09:40 AM Test Summary: 1 of 73943 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6824

  4. Oliver Klee commented on patch set 1 CR -1 10/23/20, 09:46

    Overview.html:49 Unresolved

    This needs to have type="button" so the button does not act as a submit button (which is the default type for buttons).
  5. Elisabeth Zeilinger uploaded patch set 2 10/23/20, 11:57

  6. TYPO3com voted on patch set 2 V -1 10/23/20, 11:58 Completed build in 22s on Fri, 23 Oct, 11:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6839

  7. Michael Telgkamp uploaded patch set 3 10/23/20, 12:26

  8. TYPO3com voted on patch set 3 V -1 10/23/20, 12:27 Completed build in 28s on Fri, 23 Oct, 12:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6840

  9. Michael Telgkamp uploaded patch set 4 10/23/20, 12:35

  10. TYPO3com voted on patch set 4 V +1 10/23/20, 12:48 Completed build in 12m 07s on Fri, 23 Oct, 12:48 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6841

  11. Martin Kutschker commented on patch set 4 10/30/20, 10:45

    Works nicely, but what I find odd is that cursor-right closes the menu, when there is no submenu. This works differently to what I'm used to from desktop applications. I see no obligation in the ARIA best practices to implement that way.
  12. Michael Telgkamp uploaded patch set 5 10/30/20, 13:24

  13. TYPO3com voted on patch set 5 V +1 10/30/20, 13:36 Completed build in 11m 41s on Fri, 30 Oct, 01:36 PM Test Summary: 73557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7032

  14. Michael Telgkamp commented on patch set 5 10/30/20, 13:36

    > Patch Set 4: > > Works nicely, but what I find odd is that cursor-right closes the menu, when there is no submenu. This works differently to what I'm used to from desktop applications. I see no obligation in the ARIA best practices to implement that way. With patchset 5 I made some code improvements. I cannot reproduce the menu being closed on right arrow press. If there is no submenu there is nothing done by the script. See ContextMenu.ts lines 225..229. I can reproduce closing the menu with left arrow key, but this is intended as the menu can be seen as a button menu and a button menu behaves like a submenu as there are no sibling elements like for a menu bar. New in patchset 5 is also the handling of the space button to activate the current menu item.
  15. Martin Kutschker commented on patch set 5 10/30/20, 15:25

    > Patch Set 5: > > I can reproduce closing the menu with left arrow key, but this is intended as the menu can be > seen as a button menu and a button menu behaves like a submenu as there are no sibling > elements like for a menu bar. There is no reason to assume a context menu is invoked by an imagined menu button: "A menu is usually opened, or made visible, by activating a menu button, choosing an item in a menu that opens a sub menu, or by invoking a command, such as Shift + F10 in Windows, that opens a context specific menu." A real context menu is not closed cursor keys left or right. But that's nit picking. I'm about to do some screen reader testing :)
  16. Martin Kutschker commented on patch set 5 10/30/20, 15:47

    > Patch Set 5: > I can reproduce closing the menu with left arrow key, but this is intended Sorry, you are correct, the right cursor key does not close the menu.
  17. Martin Kutschker uploaded patch set 6 10/30/20, 17:32

  18. TYPO3com voted on patch set 6 V +1 10/30/20, 17:44 Completed build in 11m 59s on Fri, 30 Oct, 05:44 PM Test Summary: 73557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7038

  19. Martin Kutschker uploaded patch set 7 10/31/20, 09:54

  20. Martin Kutschker commented on patch set 7 10/31/20, 09:59

    I add roles to menu and menu items. Without the roles NVDA suppressed the keydown events (tested with FF). With the current versions of Chrome+Jaws and FF+NVDA the menu works as expected. PS: Is there a better way to comment your own patchset?
  21. TYPO3com voted on patch set 7 V +1 10/31/20, 10:07 Completed build in 12m 22s on Sat, 31 Oct, 10:07 AM Test Summary: 73555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7044

  22. Martin Kutschker uploaded patch set 8 10/31/20, 10:21

  23. Martin Kutschker commented on patch set 8 10/31/20, 10:21

    Added support for home/end
  24. TYPO3com voted on patch set 8 V +1 10/31/20, 10:37 Completed build in 14m 01s on Sat, 31 Oct, 10:37 AM Test Summary: 73557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7046

  25. Martin Kutschker uploaded patch set 9 11/07/20, 21:27

  26. TYPO3com voted on patch set 9 V -1 11/07/20, 21:27 Completed build in 19s on Sat, 7 Nov, 09:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7180

  27. Martin Kutschker uploaded patch set 10 11/07/20, 21:39

  28. TYPO3com voted on patch set 10 V -1 11/07/20, 22:08 Completed build in 20m 57s on Sat, 7 Nov, 10:08 PM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7182

  29. Martin Kutschker uploaded patch set 11 11/14/20, 10:11

  30. TYPO3com voted on patch set 11 V -1 11/14/20, 10:23 Completed build in 11m 23s on Sat, 14 Nov, 10:23 AM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7301

  31. Andreas Kienast uploaded patch set 12 11/14/20, 19:53

  32. TYPO3com voted on patch set 12 V -1 11/14/20, 20:11 Completed build in 14m 24s on Sat, 14 Nov, 08:10 PM Test Summary: 73621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7311

  33. Michael Telgkamp uploaded patch set 13 11/14/20, 20:18

  34. Michael Telgkamp uploaded patch set 14 11/14/20, 20:30

  35. TYPO3com commented on patch set 13 11/14/20, 20:34 Completed build in 16m 25s on Sat, 14 Nov, 08:34 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7313

  36. TYPO3com voted on patch set 14 V +1 11/14/20, 20:46 Completed build in 16m 27s on Sat, 14 Nov, 08:46 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7314

  37. Benni Mack uploaded patch set 15 11/20/20, 15:31

  38. Benni Mack uploaded patch set 16 11/20/20, 15:33

  39. TYPO3com voted on patch set 15 V -1 11/20/20, 15:38 Completed build in 33s on Fri, 20 Nov, 03:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7477

  40. Benni Mack updated the commit message in patch set 17 11/20/20, 15:43

  1. TYPO3com voted on patch set 16 V +1 11/20/20, 15:54 Completed build in 16m 27s on Fri, 20 Nov, 03:54 PM Test Summary: 32389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7478

  2. Benni Mack uploaded patch set 18 11/20/20, 16:07

  3. Benni Mack voted on patch set 18 V +1 CR +1 11/20/20, 16:08

  4. TYPO3com voted on patch set 17 V +1 11/20/20, 16:11 Completed build in 16m 55s on Fri, 20 Nov, 04:11 PM Test Summary: 32389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7482

  5. Anja Leichsenring commented on patch set 18 V -1 11/20/20, 16:24

    I have a problem in PageTree with this: I highlight one page with the mouse, press Shift+F10 -> context menu opens, selecting Edit, Enter will open the page properties edit form for the selected page = all good. Now navigate elsewhere in the page tree using keyboad, pressing Shift+F10 again -> no the page properties are for a unrelated page! And this page is not highlighted in the page tree. I might have made errors by using the keyboard, but please someone verify that we don't introduce any misbehavior here. Feel free to override my -1, if my concern is not justified. Otherwise: I love the growing set of parts of the backend I can access without mouse, thank you for all the work!
  6. Benni Mack commented on patch set 18 V -1 CR 0 11/20/20, 16:38

    Yes. PageTree is not working 100%, just re-tested. Works fine within modules.
  7. TYPO3com voted on patch set 18 V +1 11/20/20, 16:41 Completed build in 25m 40s on Fri, 20 Nov, 04:41 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7486

  8. Michael Telgkamp commented on patch set 18 11/20/20, 16:54

    > Patch Set 18: Verified-1 > > I have a problem in PageTree with this: > > I highlight one page with the mouse, press Shift+F10 -> context menu opens, selecting Edit, Enter will open the page properties edit form for the selected page = all good. > Now navigate elsewhere in the page tree using keyboad, pressing Shift+F10 again -> no the page properties are for a unrelated page! And this page is not highlighted in the page tree. Actually this (unwanted) behaviour is the same if you right-click on an Pagetree-element and select Edit. You also can edit the page properties of an unrelated page. > I might have made errors by using the keyboard, but please someone verify that we don't introduce any misbehavior here. Feel free to override my -1, if my concern is not justified. Your concern is justified, but it might need to be considered in another bug, as it is a general unwanted behaviour not related to the keyboard usage added in this patch. > Otherwise: I love the growing set of parts of the backend I can access without mouse, thank you for all the work! Thank you!
  9. Benni Mack commented on patch set 18 V +1 CR +1 11/21/20, 21:32

    Thanks for the explanation. This is a separate issue.
  10. Oli Bartsch commented on patch set 18 V -1 11/24/20, 11:49

    Works for me. We unfortunately have one special case in DatabaseRecordList. The icon of a localized row gets some margin added which now leads to wrong visual representation of the button. Please have a look at my screenshot: https://forge.typo3.org/issues/89496#note-24.
  11. Oli Bartsch commented on patch set 18 11/24/20, 12:20

    > Patch Set 18: Verified-1 > > Works for me. > > We unfortunately have one special case in DatabaseRecordList. The icon of a localized row gets some margin added which now leads to wrong visual representation of the button. Please have a look at my screenshot: https://forge.typo3.org/issues/89496#note-24. Just found another place in the localization overview (See screenshot in the issue). Maybe there are some more.
  12. Elisabeth Zeilinger uploaded patch set 19 11/25/20, 10:18

  13. TYPO3com voted on patch set 19 V +1 11/25/20, 10:29 Completed build in 10m 32s on Wed, 25 Nov, 10:29 AM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7566

  14. Elisabeth Zeilinger commented on patch set 19 V -1 11/25/20, 11:29

    > Patch Set 18: > > > Patch Set 18: Verified-1 > > > > Works for me. > > > > We unfortunately have one special case in DatabaseRecordList. The icon of a localized row gets some margin added which now leads to wrong visual representation of the button. Please have a look at my screenshot: https://forge.typo3.org/issues/89496#note-24. > > Just found another place in the localization overview (See screenshot in the issue). Maybe there are some more. The margin for DatabaseRecordList is solved with patch set 19. The Localization Overview still has some issues. It should be implemented like the Pagetree Overview in the Info module.
  15. Oli Bartsch commented on patch set 19 V -1 11/25/20, 11:55

    _element_tree.scss:229 Unresolved

    There is already a definition in L:349, let's combine so we don't have multiple places for settings regarding the InfoModuleController

    BackendUtility.php:2414 Unresolved

    The new parameter is missing in the PHPDoc. Also please be aware this method is public API, changing the method signature must therefore be well documented in any case. However, since there are also parameters, which are already deprecated, this could easily get us into trouble. E.g. there is already a mapping of this method for the extension scanner wich assumes that there are a maximum of 4 parameters. Now this would be 5, and so on. All in all, I suggest to search for another solution in the first place and not to change this method for the time being.
  16. Elisabeth Zeilinger uploaded patch set 20 11/29/20, 16:33

  17. TYPO3com voted on patch set 20 V +1 11/29/20, 16:44 Completed build in 10m 54s on Sun, 29 Nov, 04:44 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7688

  18. Elisabeth Zeilinger commented on patch set 20 11/29/20, 17:08

    > Patch Set 20: Verified+1 > > Completed build in 10m 54s on Sun, 29 Nov, 04:44 PM > Test Summary: 32404 passed > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7688 The button for opening the context menu should be a <button..> and not <a href..>. This task will be tackled in another issue and not in this one. It is a separate task which affects multiple areas in the backend and needs more time and tests to be implemented. The keyboard usage of the context menu works, whether it is initiated by <a href..> or <button..>. Therefore the implementation (see latest changes in Patch 19) to change the opening button <a href..> to a <button> has been reverted in Patch 20.
  19. Benni Mack uploaded patch set 21 12/04/20, 18:20

  20. TYPO3com voted on patch set 21 V -1 12/04/20, 18:29 Completed build in 08m 48s on Fri, 4 Dec, 06:29 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7806

  21. Oli Bartsch uploaded patch set 22 12/05/20, 11:02

  22. TYPO3com voted on patch set 22 V +1 12/05/20, 11:18 Completed build in 15m 52s on Sat, 5 Dec, 11:18 AM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7821

  23. Oli Bartsch voted on patch set 22 V +1 CR +1 12/05/20, 11:29

  24. Benni Mack voted on patch set 22 V +2 CR +2 12/05/20, 11:41

  25. Benni Mack merged patch set 23 12/05/20, 11:41