Review main Merged

66261[TASK] Removed unknown aria attribute from modules menu

Torben Hansen CR +2 V +2 Easy +3 −4 updated 11/10/20, 19:05

Commit message

Removed an unknown aria attribute from the modules menu
and added an `aria-controls` attribute to 1st level menu
items.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Martin Kutschker +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Martin Kutschker +1
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 79

  1. Torben Hansen uploaded patch set 1 10/23/20, 10:29

  2. Torben Hansen wrote 10/23/20, 10:30

    Topic set to a11y
  3. TYPO3com voted on patch set 1 V -1 10/23/20, 10:48 Completed build in 14m 18s on Fri, 23 Oct, 10:48 AM Test Summary: 73457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6830

  4. Torben Hansen uploaded patch set 2 10/23/20, 11:16

  5. TYPO3com voted on patch set 2 V +1 10/23/20, 11:30 Completed build in 13m 12s on Fri, 23 Oct, 11:30 AM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6837

  6. Michael Telgkamp voted on patch set 2 V +1 CR +1 11/06/20, 10:29

  7. Martin Kutschker voted on patch set 2 V +1 CR +1 11/09/20, 17:17

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 11/10/20, 19:05

  9. Christian Kuhn merged patch set 3 11/10/20, 19:05