Review main Merged Breaking

66265[!!!][TASK] Remove LinkHandler class in linkvalidator

Sybille Peters CR +2 V +2 Hard +68 −256 updated 11/20/20, 13:51

Commit message

Linkvalidator ships with several Linktype classes that are
used to check specific links such as ExternalLinktype,
Filelinktype etc.

The Linktype LinkHandler is not used by default (see
Page TSconfig mod.linkvalidator.linktypes).

It was used to check links of the extension "linkhandler"
which is now outdated. The latest version supports TYPO3
4.1.0. Functionality from the extension linkhandler has
been migrated to the core in TYPO3 8, but in any case
the LinkHandler link type supports outdated link syntax
starting with "record:".

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1118

  1. Sybille Peters uploaded patch set 1 10/23/20, 14:03

  2. Sybille Peters updated the commit message in patch set 2 10/23/20, 14:08

  3. TYPO3com voted on patch set 1 V +1 10/23/20, 14:16 Completed build in 13m 40s on Fri, 23 Oct, 02:16 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6848

  4. TYPO3com voted on patch set 2 V +1 10/23/20, 14:21 Completed build in 13m 10s on Fri, 23 Oct, 02:21 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6849

  5. Sybille Peters uploaded patch set 3 10/23/20, 14:48

  6. TYPO3com voted on patch set 3 V +1 10/23/20, 15:01 Completed build in 13m 17s on Fri, 23 Oct, 03:01 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6850

  7. Sybille Peters wrote 10/23/20, 17:16

    Topic set to Linkvalidator
  8. Sybille Peters uploaded patch set 4 11/03/20, 14:38

  9. Sybille Peters updated the commit message in patch set 5 11/03/20, 14:44

  10. TYPO3com voted on patch set 4 V +1 11/03/20, 14:57 Completed build in 13m 58s on Tue, 3 Nov, 02:57 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7091

  11. TYPO3com voted on patch set 5 V +1 11/03/20, 15:02 Completed build in 18m 04s on Tue, 3 Nov, 03:02 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7092

  12. Sybille Peters updated the commit message in patch set 6 11/03/20, 15:54

  13. TYPO3com voted on patch set 6 V +1 11/03/20, 16:06 Completed build in 11m 34s on Tue, 3 Nov, 04:06 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7093

  14. Anja Leichsenring commented on patch set 7 11/20/20, 13:28

    Published edit on patch set 6.
  15. TYPO3com voted on patch set 7 V +1 11/20/20, 13:42 Completed build in 11m 31s on Fri, 20 Nov, 01:42 PM Test Summary: 32377 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7461

  16. Christian Kuhn voted on patch set 7 V +1 CR +1 11/20/20, 13:48

  17. Anja Leichsenring voted on patch set 7 V +2 CR +2 11/20/20, 13:51

  18. Anja Leichsenring merged patch set 8 11/20/20, 13:51