Review main Merged

66270[BUGFIX] Allow keyboard usage of file upload dropzone

Olaf Schmidt-Wischhöfer CR +2 V +2 Easy +17 −6 updated 11/05/20, 16:01

Commit message

The dropzone for file uploads now uses two <button> tags
instead of <div> tags. One for the dropzone itself and
the other one for the close button.

The dropzone button now has got an `aria-labelledby`
attribute pointing to the dropzone title. The close
button got an `aria-label` attribute. Both to support
screen readers.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Daniel Haupt +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Daniel Haupt +1
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1519

  1. Olaf Schmidt-Wischhöfer uploaded patch set 1 10/23/20, 15:40

  2. TYPO3com voted on patch set 1 V +1 10/23/20, 15:53 Completed build in 12m 20s on Fri, 23 Oct, 03:53 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6855

  3. Olaf Schmidt-Wischhöfer wrote 10/23/20, 19:39

    Topic set to a11y
  4. Olaf Schmidt-Wischhöfer uploaded patch set 2 10/23/20, 19:47

  5. TYPO3com voted on patch set 2 V +1 10/23/20, 20:00 Completed build in 12m 11s on Fri, 23 Oct, 08:00 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6863

  6. Daniel Haupt voted on patch set 2 V +1 CR +1 10/24/20, 09:29

  7. Oli Bartsch uploaded patch set 3 10/26/20, 09:58

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 10/26/20, 10:01

  9. TYPO3com voted on patch set 3 V +1 10/26/20, 10:09 Completed build in 11m 42s on Mon, 26 Oct, 10:09 AM Test Summary: 73558 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6882

  10. Olaf Schmidt-Wischhöfer commented on patch set 3 10/26/20, 10:39

    > Patch Set 3: Verified+1 Code-Review+1 Thank you, Oliver, for these additions. They look good.
  11. Michael Telgkamp commented on patch set 3 V +1 CR +1 10/29/20, 13:01

    Nice, looks good for me.
  12. Daniel Haupt voted on patch set 3 V +1 CR +1 11/01/20, 23:30

  13. Michael Telgkamp uploaded patch set 4 11/05/20, 13:44

  14. Michael Telgkamp commented on patch set 4 V +1 CR +1 11/05/20, 13:47

    As this review already had the most upvotes of the reviews with a conflicting backend.css I updated the backend.css and pushed this a new patchset. So no changes here, just a regenerated backend.css.
  15. TYPO3com voted on patch set 4 V +1 11/05/20, 14:27 Completed build in 14m 40s on Thu, 5 Nov, 02:27 PM Test Summary: 73593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7133

  16. Daniel Haupt voted on patch set 4 V +1 CR +1 11/05/20, 15:26

  17. Oli Bartsch voted on patch set 4 V +1 CR +1 11/05/20, 15:28

  18. Benni Mack voted on patch set 4 V +2 CR +2 11/05/20, 16:01

  19. Benni Mack merged patch set 5 11/05/20, 16:01