Review main Merged

66271[BUGFIX] Use a HTML button for the collapsable IRRE header

Olaf Schmidt-Wischhöfer CR +2 V +2 Normal +69 −19 updated 11/20/20, 16:00

Commit message

Also add aria-expanded and aria-controls arguments for screen readers

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benni Mack +2
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 811

  1. Olaf Schmidt-Wischhöfer uploaded patch set 1 10/23/20, 15:46

  2. TYPO3com voted on patch set 1 V -1 10/23/20, 15:58 Completed build in 11m 48s on Fri, 23 Oct, 03:58 PM Test Summary: 1 of 73943 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6856

  3. Olaf Schmidt-Wischhöfer uploaded patch set 2 10/23/20, 19:13

  4. TYPO3com voted on patch set 2 V +1 10/23/20, 19:25 Completed build in 12m 22s on Fri, 23 Oct, 07:25 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6862

  5. Olaf Schmidt-Wischhöfer wrote 10/23/20, 19:39

    Topic set to a11y
  6. Michael Telgkamp commented on patch set 2 V +1 CR +1 10/29/20, 09:45

    This fixes the issue with keyboard usability, but the frontend looks the same. Thus it should be backported to v10.
  7. Benni Mack uploaded patch set 3 11/20/20, 15:35

  8. TYPO3com voted on patch set 3 V +1 11/20/20, 15:58 Completed build in 20m 01s on Fri, 20 Nov, 03:58 PM Test Summary: 32389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7479

  9. Michael Telgkamp voted on patch set 3 V +1 CR +1 11/20/20, 15:59

  10. Benni Mack voted on patch set 3 V +2 CR +2 11/20/20, 16:00

  11. Benni Mack merged patch set 4 11/20/20, 16:00