66272[WIP][FEATURE] Introduce a lowlevel FileSystem API
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 2
Review log 67
-
Benni Mack uploaded patch set 1 10/23/20, 16:13
-
TYPO3com voted on patch set 1 V -1 10/23/20, 16:14 Completed build in 22s on Fri, 23 Oct, 04:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6857
-
Alexander Schnitzler commented on patch set 1 10/26/20, 08:51
What do you think about using symfony/filesystem and similar packages here for several low level functions we don't have to reimplement then ourselves. -
Benni Mack commented on patch set 1 10/26/20, 13:08
> Patch Set 1: > > What do you think about using symfony/filesystem and similar packages here for several low level functions we don't have to reimplement then ourselves. Thanks for the review and feedback! Already thought of that, the main reason I continued this path is that we provide some additional layers in our existing API - fixPermission - EXT: resolving - allowed paths (lockRootPath) and then Symfony's Filesystem API has some things just don't need. -
Alexander Schnitzler commented on patch set 1 10/26/20, 15:16
> Patch Set 1: > > > Patch Set 1: > > > > What do you think about using symfony/filesystem and similar packages here for several low level functions we don't have to reimplement then ourselves. > Thanks for the review and feedback! > > Already thought of that, the main reason I continued this path is that we provide some additional layers in our existing API > - fixPermission > - EXT: resolving > - allowed paths (lockRootPath) > > and then Symfony's Filesystem API has some things just don't need. I don't think this patch would be superfluous. This class could still exist and be a wrapper for just some methods. wdyt? -
Benni Mack commented on patch set 1 11/30/20, 11:22
> Patch Set 1: > > > Patch Set 1: > > > > > Patch Set 1: > > > > > > What do you think about using symfony/filesystem and similar packages here for several low level functions we don't have to reimplement then ourselves. > > Thanks for the review and feedback! > > > > Already thought of that, the main reason I continued this path is that we provide some additional layers in our existing API > > - fixPermission > > - EXT: resolving > > - allowed paths (lockRootPath) > > > > and then Symfony's Filesystem API has some things just don't need. > > I don't think this patch would be superfluous. This class could still exist and be a wrapper for just some methods. wdyt? We could add a wrapper, but I think Symfony's Filesystem API is not "sharp" enough for our use cases (you can chmod on iterable|string without having typehints). And I think the Symfony class is not as "speaking" as our existing code. -
Benni Mack abandoned the change 09/07/21, 18:54