66273[TASK] Provide label for email field in forget password form
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1012
-
Matthias Weber uploaded patch set 1 10/23/20, 16:25
-
Matthias Weber wrote 10/23/20, 16:25
Topic set to a11y -
TYPO3com voted on patch set 1 V +1 10/23/20, 16:38 Completed build in 12m 29s on Fri, 23 Oct, 04:38 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6858
-
Ingo Fabbri voted on patch set 1 CR +1 10/24/20, 12:28
-
Daniel Haupt commented on patch set 1 CR -1 10/24/20, 12:33
ForgetPasswordForm.html:26We can not use this translation key here as it belongs to ext:form (which is probably not installed). See location of other translation keys used in this template or change to 'E-Mail' only without using any translation at all. -
Oli Bartsch commented on patch set 1 CR -1 10/26/20, 09:25
Is there another patch adding labels to the fields for Login / Rest password? Otherwise I would suggest adding them here to unify the display through all these templates.ForgetPasswordForm.html:26Reply UnresolvedThere is a dedicated locallang file locallang_reset_password.xlf for these labels. -
Oli Bartsch uploaded patch set 2 11/20/20, 15:37
-
Oli Bartsch voted on patch set 2 V +1 CR +1 11/20/20, 15:39
-
Christian Kuhn voted on patch set 2 V +1 CR +1 11/20/20, 15:50
-
Benni Mack voted on patch set 2 V +2 CR +2 11/20/20, 15:51
-
TYPO3com voted on patch set 2 V +1 11/20/20, 16:02 Completed build in 24m 13s on Fri, 20 Nov, 04:02 PM Test Summary: 32389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7480
-
Benni Mack merged patch set 3 11/20/20, 16:04