Review main Merged

66274[DOCS] Remove Developer page from Linkvalidator docs

Sybille Peters CR +2 V +2 Easy +0 −40 updated 11/11/20, 09:24

Commit message

The Developer page explained how link handling is done
in the RTE. This is not specific to linkvalidator and
may change in the future.

Understanding how the existing events work can be
better done by looking in the core.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Oliver Klee +1
    • Björn Jacob +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1720

  1. Sybille Peters uploaded patch set 1 10/23/20, 16:40

  2. TYPO3com voted on patch set 1 V +1 10/23/20, 16:53 Completed build in 12m 54s on Fri, 23 Oct, 04:53 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6859

  3. Sybille Peters wrote 10/23/20, 17:16

    Topic set to linkvalidator
  4. Sybille Peters uploaded patch set 2 10/27/20, 18:00

  5. TYPO3com voted on patch set 2 V +1 10/27/20, 18:26 Completed build in 20m 17s on Tue, 27 Oct, 06:26 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6931

  6. Sybille Peters uploaded patch set 3 10/29/20, 20:37

  7. TYPO3com voted on patch set 3 V +1 10/29/20, 20:50 Completed build in 13m 20s on Thu, 29 Oct, 08:50 PM Test Summary: 73554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7016

  8. Björn Jacob voted on patch set 3 V +1 CR +1 10/30/20, 09:20

  9. Oliver Klee voted on patch set 3 CR +1 10/30/20, 13:48

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 11/01/20, 17:39

  11. Sybille Peters wrote 11/03/20, 14:53

    Topic linkvalidator removed
  12. Sybille Peters wrote 11/03/20, 14:53

    Topic set to Linkvalidator
  13. Daniel Goerz commented on patch set 3 11/04/20, 18:25

    Don't know. I find this information kind of useful.
  14. Anja Leichsenring commented on patch set 3 CR -1 11/04/20, 18:56

    actually, if the information is not plain wrong, I would prefer to keep it. This is exactly that kind of information, that a developer would look for in exactly this place, and this is also not available elsewhere.
  15. Christian Kuhn commented on patch set 3 11/10/20, 22:24

    @anja - i agree with Sybille here: This docs part represents only a fraction of what link validator does and tries to explain what rte does at the same time (which looks outdated). I guess we could drop that part without too much trouble.
  16. Christian Kuhn voted on patch set 3 CR +1 11/10/20, 22:25

  17. Anja Leichsenring commented on patch set 3 CR 0 11/11/20, 06:44

    okay then
  18. Josef Glatz voted on patch set 3 V +1 CR +1 11/11/20, 07:51

  19. Daniel Goerz voted on patch set 3 V +2 CR +2 11/11/20, 09:24

  20. Daniel Goerz merged patch set 4 11/11/20, 09:24