66276[TASK] Add label to toolbar search field
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Michael Telgkamp +1
-
Verified V +2 Done
- Benni Mack +2
- Michael Telgkamp +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1215
-
Matthias Weber uploaded patch set 1 10/23/20, 18:28
-
Matthias Weber wrote 10/23/20, 18:28
Topic set to a11y -
Matthias Weber commented on patch set 1 10/23/20, 18:33
Hi Michael, in addition to what we discussed in the sprint, I disabled the pointer-events for the .form-control-icon class. It sounds rather generic but is only used for the toolbar search field. Matthias -
TYPO3com voted on patch set 1 V +1 10/23/20, 18:42 Completed build in 13m 57s on Fri, 23 Oct, 06:42 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6861
-
Daniel Haupt voted on patch set 1 V +1 CR +1 10/24/20, 09:35
-
Ingo Fabbri commented on patch set 1 CR -1 10/24/20, 12:37
LiveSearchToolbarItem.html:10I would provide a more meaningful label. As far I saw, the language-key "toolbarItems.search" resolved to "Search". So a screenreader would speak: "search Search" (because of the form's "role=search"). Maybe move the aria-label to the parent form-tag and change the label to something meaningful. I am not sure where this template is used in backend - is it the search-input top right? Then maybe arial-label "system-wide in all records" would speak "search system-wide in all records" -
Martin Kutschker uploaded patch set 2 11/28/20, 16:32
-
Martin Kutschker commented on patch set 2 11/28/20, 16:33
LiveSearchToolbarItem.html:10ReplyThe role search may not be announced. So omitting "search" completely is not an option. https://www.bbc.com/ opts for "search the bbc". I suggest "search the contents". -
TYPO3com voted on patch set 2 V +1 11/28/20, 16:42 Completed build in 10m 20s on Sat, 28 Nov, 04:42 PM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7672
-
Martin Kutschker uploaded patch set 3 12/06/20, 11:16
-
TYPO3com voted on patch set 3 V +1 12/06/20, 11:25 Completed build in 09m 26s on Sun, 6 Dec, 11:25 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7848
-
Michael Telgkamp voted on patch set 3 V +1 CR +1 12/06/20, 13:43
-
Martin Kutschker commented on patch set 3 12/09/20, 21:06
LiveSearchToolbarItem.html:10ReplyDone -
Benni Mack voted on patch set 3 V +2 CR +2 12/10/20, 22:43
-
Benni Mack merged patch set 4 12/10/20, 22:43