Review main Abandoned

66279[FEATURE] Introduce LinkTargetCache for linkvalidator

Sybille Peters CR 0 V 0 Hard +389 −68 updated 05/14/21, 14:11

Commit message

A new LinkTargetCache is introduced to cache external link targets.

Previously, external link targets were cached as well in an array in
ExternalLinktype, but this was volatile and could not be resused.

The change will reduce external link target checking, make the
process more configurable and also paves way for new features,
where link checking can be done on-the-fly.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 1420

  1. Sybille Peters uploaded patch set 1 10/24/20, 18:24

  2. TYPO3com voted on patch set 1 V -1 10/24/20, 18:36 Completed build in 11m 50s on Sat, 24 Oct, 06:36 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6866

  3. Sybille Peters uploaded patch set 2 10/25/20, 13:21

  4. Sybille Peters uploaded patch set 3 10/25/20, 13:29

  5. TYPO3com voted on patch set 2 V -1 10/25/20, 13:34 Completed build in 12m 10s on Sun, 25 Oct, 01:34 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6871

  6. TYPO3com voted on patch set 3 V +1 10/25/20, 13:41 Completed build in 12m 26s on Sun, 25 Oct, 01:41 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6872

  7. Sybille Peters uploaded patch set 4 10/25/20, 13:48

  8. TYPO3com voted on patch set 4 V -1 10/25/20, 14:00 Completed build in 11m 53s on Sun, 25 Oct, 02:00 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6874

  9. Sybille Peters uploaded patch set 5 10/25/20, 15:17

  10. TYPO3com voted on patch set 5 V +1 10/25/20, 15:29 Completed build in 11m 25s on Sun, 25 Oct, 03:29 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6875

  11. Sybille Peters wrote 11/03/20, 15:00

    Topic set to Linkvalidator
  12. Sybille Peters commented on patch set 5 11/03/20, 15:00

    This change is ready for review.
  13. Sybille Peters commented on patch set 5 CR -1 11/20/20, 18:48

    This needs some more work. In particular, the caching should probably not be added to the Linktype class directly and then needs some more refactoring
  14. Sybille Peters marked it work in progress 11/20/20, 18:48

  15. Sybille Peters uploaded patch set 6 12/29/20, 18:07

  16. Sybille Peters marked it ready for review 12/29/20, 18:07

  17. TYPO3com voted on patch set 6 V +1 12/29/20, 18:17 Completed build in 09m 59s on Tue, 29 Dec, 06:17 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8495

  18. Sybille Peters voted on patch set 6 CR -1 02/04/21, 06:50

  19. Sybille Peters commented on patch set 6 05/14/21, 14:11

    I have implemented this feature now in my extension "brofix" (based on linkvalidator), but using a persistent cachen, not via the caching framework. The problem with the caching framework is, it will be flushed every time the cache is flushed. My implementation in the other extension is that the cache has an expiration date which is configurable which gives you more control over how long the cache will be used. Will abandon.
  20. Sybille Peters abandoned the change 05/14/21, 14:11

    See last note. Implementation should be done without caching framework.