66279[FEATURE] Introduce LinkTargetCache for linkvalidator
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Feature-92700-AddCacheForExternalLinkTargets.rstnew+52 −0
- typo3/sysext/linkvalidator/Classes/LinkTargetCache/LinkTargetCache.phpnew+108 −0
- typo3/sysext/linkvalidator/Classes/Linktype/AbstractLinktype.php+7 −0
- typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php+35 −6
- typo3/sysext/linkvalidator/Configuration/TsConfig/Page/pagetsconfig.tsconfig+4 −4
- typo3/sysext/linkvalidator/Tests/Unit/Linktype/ExternalLinktypeTest.php+171 −58
- typo3/sysext/linkvalidator/ext_localconf.php+12 −0
Review log 1420
-
Sybille Peters uploaded patch set 1 10/24/20, 18:24
-
TYPO3com voted on patch set 1 V -1 10/24/20, 18:36 Completed build in 11m 50s on Sat, 24 Oct, 06:36 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6866
-
Sybille Peters uploaded patch set 2 10/25/20, 13:21
-
Sybille Peters uploaded patch set 3 10/25/20, 13:29
-
TYPO3com voted on patch set 2 V -1 10/25/20, 13:34 Completed build in 12m 10s on Sun, 25 Oct, 01:34 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6871
-
TYPO3com voted on patch set 3 V +1 10/25/20, 13:41 Completed build in 12m 26s on Sun, 25 Oct, 01:41 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6872
-
Sybille Peters uploaded patch set 4 10/25/20, 13:48
-
TYPO3com voted on patch set 4 V -1 10/25/20, 14:00 Completed build in 11m 53s on Sun, 25 Oct, 02:00 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6874
-
Sybille Peters uploaded patch set 5 10/25/20, 15:17
-
TYPO3com voted on patch set 5 V +1 10/25/20, 15:29 Completed build in 11m 25s on Sun, 25 Oct, 03:29 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6875
-
Sybille Peters wrote 11/03/20, 15:00
Topic set to Linkvalidator -
Sybille Peters commented on patch set 5 11/03/20, 15:00
This change is ready for review. -
Sybille Peters commented on patch set 5 CR -1 11/20/20, 18:48
This needs some more work. In particular, the caching should probably not be added to the Linktype class directly and then needs some more refactoring -
Sybille Peters marked it work in progress 11/20/20, 18:48
-
Sybille Peters uploaded patch set 6 12/29/20, 18:07
-
Sybille Peters marked it ready for review 12/29/20, 18:07
-
TYPO3com voted on patch set 6 V +1 12/29/20, 18:17 Completed build in 09m 59s on Tue, 29 Dec, 06:17 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8495
-
Sybille Peters voted on patch set 6 CR -1 02/04/21, 06:50
-
Sybille Peters commented on patch set 6 05/14/21, 14:11
I have implemented this feature now in my extension "brofix" (based on linkvalidator), but using a persistent cachen, not via the caching framework. The problem with the caching framework is, it will be flushed every time the cache is flushed. My implementation in the other extension is that the cache has an expiration date which is configurable which gives you more control over how long the cache will be used. Will abandon. -
Sybille Peters abandoned the change 05/14/21, 14:11
See last note. Implementation should be done without caching framework.