Review TYPO3_4-6 Merged Breaking

6628[BUGFIX][!!!] Slider wizard misuses "max" property

Francois Suter CR +2 V +2 Easy +8 −2 updated 06/03/13, 20:49

Commit message

TYPO3 4.6 introduced a slider wizard for select-type and
input-type fields. For input-type fields it is possible
to define a minimum and maximum value for the slider.
Unfortunately the wizard misuses the "max" TCA property
for the maximum value, which is normally used for the
"maxlength" attribute of the input field.

The slider wizard should instead rely on the "range" property,
which already exists and serves exactly the purpose of defining
a minimum and maximum value for the field.

Review

  • Code review CR +2
    • Francois Suter +2
  • Verified V +2
    • Francois Suter +2

Files 1

Review log 2

  1. Francois Suter commented on patch set 1 V 0 11/11/11, 14:44

    by team member; Looks good to me, approved Same code as in master and principle validated in mailing list.
  2. Francois Suter merged patch set 1 11/11/11, 14:44