Review main Merged

66281[TASK] Build extbase requests early in Bootstrap

Alexander Schnitzler CR +2 V +2 Normal +41 −43 updated 10/27/20, 20:50

Commit message

This patch introduces a couple of changes to the extbase request
creation and handling process.

The request builder is used during bootstrap to create an extbase
request object. This enables building the extbase request from the
incoming server request in the future without passing the server
request through a layer of services.

Further, it enables a more sensible API for the request handlers
whose methods canHandleRequest() and handleRequest() did not receive
the extbase request as arguments for evaluation in the past.

The idea is to have the extbase request and an attached context object
as single source of truth regarding request data and avoid storing
that data elsewhere or accessing it through services during runtime.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1015

  1. Alexander Schnitzler uploaded patch set 1 10/25/20, 12:59

  2. Alexander Schnitzler wrote 10/25/20, 12:59

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V +1 10/25/20, 13:11 Completed build in 12m 27s on Sun, 25 Oct, 01:11 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6869

  4. Alexander Schnitzler updated the commit message in patch set 2 10/25/20, 13:16

  5. TYPO3com voted on patch set 2 V +1 10/25/20, 13:28 Completed build in 11m 46s on Sun, 25 Oct, 01:27 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6870

  6. Benni Mack voted on patch set 2 V +1 CR +1 10/27/20, 07:03

  7. Oli Bartsch uploaded patch set 3 10/27/20, 16:35

  8. Oli Bartsch uploaded patch set 4 10/27/20, 16:36

  9. TYPO3com voted on patch set 3 V +1 10/27/20, 16:47 Completed build in 11m 58s on Tue, 27 Oct, 04:47 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6919

  10. TYPO3com voted on patch set 4 V -1 10/27/20, 16:56 Completed build in 19m 14s on Tue, 27 Oct, 04:56 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6921

  11. Oli Bartsch uploaded patch set 5 10/27/20, 16:58

  12. Oli Bartsch voted on patch set 5 V +1 CR +1 10/27/20, 17:09

  13. TYPO3com voted on patch set 5 V +1 10/27/20, 17:11 Completed build in 12m 04s on Tue, 27 Oct, 05:11 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6924

  14. Benni Mack voted on patch set 5 V +2 CR +2 10/27/20, 20:50

  15. Benni Mack merged patch set 6 10/27/20, 20:50