Review main Merged Breaking

66282[!!!][BUGFIX] Fix behaviour of inverted TCA checkboxes

Martin Kutschker CR +2 V +2 Normal +66 −76 updated 11/20/20, 15:27

Commit message

States of checkboxes defined in the TCA with "invertStateDisplay" enabled
are announced in the same way as the visual representation. The
underlaying checkbox value is inverted instead of just inverting the
corresponding visual representation.

The CSS class "checkbox-invert" used for styling these checkboxes has
been removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benni Mack +2
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1321

  1. Martin Kutschker uploaded patch set 1 10/25/20, 15:49

  2. TYPO3com voted on patch set 1 V -1 10/25/20, 15:49 Completed build in 23s on Sun, 25 Oct, 03:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6876

  3. Michael Telgkamp uploaded patch set 2 10/29/20, 13:22

  4. TYPO3com voted on patch set 2 V -1 10/29/20, 13:24 Completed build in 01m 04s on Thu, 29 Oct, 01:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7003

  5. Martin Kutschker wrote 10/29/20, 13:34

    Topic set to a11y
  6. Michael Telgkamp uploaded patch set 3 10/29/20, 13:37

  7. TYPO3com voted on patch set 3 V -1 10/29/20, 13:50 Completed build in 13m 39s on Thu, 29 Oct, 01:50 PM Test Summary: 73554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7005

  8. Michael Telgkamp uploaded patch set 4 10/29/20, 13:51

  9. TYPO3com voted on patch set 4 V +1 10/29/20, 14:04 Completed build in 12m 35s on Thu, 29 Oct, 02:04 PM Test Summary: 73554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7006

  10. Martin Kutschker uploaded patch set 5 11/08/20, 10:01

  11. TYPO3com voted on patch set 5 V +1 11/08/20, 10:13 Completed build in 11m 45s on Sun, 8 Nov, 10:13 AM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7187

  12. Michael Telgkamp commented on patch set 5 CR -1 11/09/20, 14:25

    There is a typo in the removed class name in the commit message and the rst (also the rst-filename). Additionally I think it might be useful to add some more information in the rst to clarify the impact for existing installations.

    Unresolved

    The css class is/was named `checkbox-invert`

    Breaking-92678-CssClassCheckboxInvertRemoved.rst:12 Unresolved

    The css class is/was named `checkbox-invert`

    Breaking-92678-CssClassCheckboxInvertRemoved.rst:15 Unresolved

    The information that the checkbox value itself is now inverted, should be added here to clarify why the different style is not needed any longer.

    Breaking-92678-CssClassCheckboxInvertRemoved.rst:26 Unresolved

    Actually I think the default installations of TYPO3 are not affected, as the change of the value of the checkbox does not require any action for the default handling. Only installations using the `.checkbox-invert` css class without the `invertStateDisplay` configuration are affected.

    Breaking-92678-CssClassCheckboxInvertRemoved.rst:32 Unresolved

    When using only the invertStateDisplay configuration, no migration is required. For using the `.checkbox-invert` class without setting the configuration value, the migration would be to handle the inversion of the value like it is done in this patch.
  13. Martin Kutschker uploaded patch set 6 11/14/20, 10:30

  14. TYPO3com voted on patch set 6 V +1 11/14/20, 10:41 Completed build in 11m 35s on Sat, 14 Nov, 10:41 AM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7302

  15. Andreas Kienast uploaded patch set 7 11/14/20, 19:51

  16. TYPO3com voted on patch set 7 V +1 11/14/20, 20:06 Completed build in 14m 28s on Sat, 14 Nov, 08:06 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7310

  17. Michael Telgkamp uploaded patch set 8 11/20/20, 14:43

  18. Michael Telgkamp voted on patch set 8 V +1 CR +1 11/20/20, 14:45

  19. TYPO3com voted on patch set 8 V +1 11/20/20, 14:57 Completed build in 13m 11s on Fri, 20 Nov, 02:57 PM Test Summary: 32389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7469

  20. Benni Mack voted on patch set 8 V +2 CR +2 11/20/20, 15:27

  21. Benni Mack merged patch set 9 11/20/20, 15:27