66283[FEATURE] Improve keyboard navigation for module menus
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Michael Telgkamp +1
-
Verified V +2 Done
- Richard Haeser +2
- Guido Schmechel +1
- Michael Telgkamp +1
- TYPO3com +1 CI
Issues 3
Files 11
- Build/Sources/Sass/scaffold/_modulemenu.scss+6 −2
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Element/ImmediateActionElement.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ModuleMenu.ts4+207 −30
- typo3/sysext/backend/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/backend/Resources/Private/Templates/ModuleMenu/Main.html+63 −36
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/HelpToolbarItemDropDown.html+26 −24
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Element/ImmediateActionElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ModuleMenu.js+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-92704-ImproveKeyboardNavigationForModuleMenus.rstnew+51 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/ModuleMenuButtonCest.php+7 −6
Review log 4673
Show 2748 earlier messages
-
Martin Kutschker uploaded patch set 1 10/25/20, 17:02
-
TYPO3com voted on patch set 1 V +1 10/25/20, 17:14 Completed build in 11m 55s on Sun, 25 Oct, 05:14 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6877
-
Martin Kutschker uploaded patch set 2 10/31/20, 20:08
-
TYPO3com voted on patch set 2 V -1 10/31/20, 20:27 Completed build in 18m 09s on Sat, 31 Oct, 08:27 PM Test Summary: 1 of 74042 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7059
-
Martin Kutschker uploaded patch set 3 11/01/20, 18:33
-
TYPO3com voted on patch set 3 V -1 11/01/20, 18:47 Completed build in 13m 52s on Sun, 1 Nov, 06:47 PM Test Summary: 2 of 73173 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7068
-
Martin Kutschker uploaded patch set 4 11/11/20, 21:32
-
TYPO3com voted on patch set 4 V -1 11/11/20, 21:37 Completed build in 37s on Wed, 11 Nov, 09:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7257
-
Martin Kutschker uploaded patch set 5 11/11/20, 21:38
-
TYPO3com voted on patch set 5 V -1 11/11/20, 22:23 Completed build in 20m 22s on Wed, 11 Nov, 10:23 PM Test Summary: 2 of 74129 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7259
-
Andreas Kienast uploaded patch set 6 11/14/20, 19:54
-
TYPO3com voted on patch set 6 V -1 11/14/20, 20:15 Completed build in 18m 49s on Sat, 14 Nov, 08:15 PM Test Summary: 2 of 74108 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7312
-
Martin Kutschker uploaded patch set 7 11/15/20, 12:10
-
TYPO3com voted on patch set 7 V -1 11/15/20, 12:22 Completed build in 11m 43s on Sun, 15 Nov, 12:22 PM Test Summary: 3 of 74108 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7316
-
Martin Kutschker uploaded patch set 8 11/15/20, 15:32
-
TYPO3com voted on patch set 8 V -1 11/15/20, 15:48 Completed build in 16m 00s on Sun, 15 Nov, 03:48 PM Test Summary: 2 of 74108 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7318
-
Martin Kutschker uploaded patch set 9 11/15/20, 16:45
-
TYPO3com voted on patch set 9 V -1 11/15/20, 16:59 Completed build in 13m 24s on Sun, 15 Nov, 04:59 PM Test Summary: 1 of 74108 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7319
-
Martin Kutschker uploaded patch set 10 11/28/20, 16:59
-
TYPO3com voted on patch set 10 V -1 11/28/20, 17:10 Completed build in 11m 05s on Sat, 28 Nov, 05:10 PM Test Summary: 1 of 32635 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7673
-
Martin Kutschker uploaded patch set 11 12/05/20, 21:50
-
TYPO3com voted on patch set 11 V +1 12/05/20, 22:00 Completed build in 09m 35s on Sat, 5 Dec, 10:00 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7840
-
Michael Telgkamp commented on patch set 11 CR -1 12/10/20, 23:00
The changes look very good and I love being able to use the keyboard on the modules, but there are some confusing parts in the behaviour, for me. Having a menubar announced I would expect it to behave like described in https://www.w3.org/TR/wai-aria-practices-1.1/#menu Having aria-orientation set to vertical, you are able to use up and down to select the menubar items, but now comes the confusing part, the subitems should be aligned horizontally for vertical menubars to allow users to select them with left right buttons. Using up and down arrows again for the second level is confusing, although it reflects the layout on the screen. For a vertical menubar the documentation says right opens the submenu and selects the last item, left opens and selects the first item. The Dashboard item in the menubar is confusing, too, because it is on the level of the groups, but when activating it, opens another view instead of the submenu. -
Michael Telgkamp commented on patch set 11 12/10/20, 23:04
ModuleMenu.ts:307UnresolvedIt looks like this is debug output that can be removed. -
Martin Kutschker commented on patch set 11 12/11/20, 16:59
Reply
I am aware of the inconsitencies. I even thought about a user preference to switch between "regular horizontal ARIA menubar" navigation and visual navgation. But it seems to be possible to set the orientation on the menubar AND the menus: "If a menubar is vertically oriented, it has aria-orientation set to vertical. The default value of aria-orientation for a menubar is horizontal." Then everything is fine. Additionally we can alias up/left and down/right for the second level. I don't understand your complaint about the dashboard. It's inconstistent for all users. But this does not break any rule about ARIA menubars. What I found more annyoing was that screen readers fail to announce that a submenu is already open. ARIA does not say that a menu closes automatically ("When a user activates a choice in a menu, the menu usually closes unless the choice opened a submenu.") but the screen readers assume so. -
Martin Kutschker uploaded patch set 12 12/27/20, 09:25
-
Martin Kutschker commented on patch set 12 12/27/20, 09:29
Reply
I have added the orientation=vertical to the submenus. As for the Dashboard, ie a menubar item that has no submenu, it acts as described in the ARIA pattern. A menubar item may have a submenu or may trigger an action. -
TYPO3com voted on patch set 12 V +1 12/27/20, 09:35 Completed build in 09m 53s on Sun, 27 Dec, 09:35 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8462
-
Martin Kutschker uploaded patch set 13 12/29/20, 21:27
-
TYPO3com voted on patch set 13 V -1 12/29/20, 21:39 Completed build in 11m 22s on Tue, 29 Dec, 09:39 PM Test Summary: 84 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8499
-
TYPO3com commented on patch set 13 01/03/21, 17:19 Completed build in 10m 25s on Sun, 3 Jan, 05:19 PM Test Summary: 83 of 32787 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8560
-
Benni Mack uploaded patch set 14 01/04/21, 14:35
-
TYPO3com voted on patch set 14 V -1 01/04/21, 14:47 Completed build in 11m 51s on Mon, 4 Jan, 02:46 PM Test Summary: 1 of 32787 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8595
-
TYPO3com voted on patch set 14 V +1 01/04/21, 15:04 Completed build in 41m 25s on Mon, 4 Jan, 03:04 PM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8595
-
Anja Leichsenring updated the commit message in patch set 15 01/04/21, 20:04
-
Anja Leichsenring commented on patch set 15 01/04/21, 20:05
please don't forget the feature rst file. This feature deserves one. -
TYPO3com voted on patch set 15 V +1 01/04/21, 20:14 Completed build in 09m 53s on Mon, 4 Jan, 08:14 PM Test Summary: 32545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8612
-
Martin Kutschker uploaded patch set 16 01/05/21, 16:26
-
Martin Kutschker commented on patch set 16 01/05/21, 16:27
Reply
Done. -
TYPO3com voted on patch set 16 V -1 01/05/21, 16:39 Completed build in 12m 09s on Tue, 5 Jan, 04:39 PM Test Summary: 1 of 32786 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8632
-
TYPO3com voted on patch set 16 V +1 01/05/21, 20:00 Completed build in 10m 01s on Tue, 5 Jan, 08:00 PM Test Summary: 32543 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8650
-
Martin Kutschker wrote 01/07/21, 09:07
Topic set to a11y -
Benjamin Franzke commented on patch set 16 CR -1 01/07/21, 09:15
Template.js:1This file should be removed. I guess it is a left-over from a rebase. It was introduced by https://review.typo3.org/c/Packages/TYPO3.CMS/+/65047 but removed by https://review.typo3.org/c/Packages/TYPO3.CMS/+/67095 in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/67092 -
Martin Kutschker uploaded patch set 17 01/07/21, 09:48
-
Martin Kutschker commented on patch set 17 01/07/21, 09:53
Template.js:1ReplyDone -
Martin Kutschker uploaded patch set 18 01/07/21, 09:54
-
TYPO3com voted on patch set 17 V -1 01/07/21, 10:14 Completed build in 19m 35s on Thu, 7 Jan, 10:14 AM Test Summary: 1 of 32806 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8724
-
TYPO3com voted on patch set 18 V +1 01/07/21, 10:24 Completed build in 29m 54s on Thu, 7 Jan, 10:24 AM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8725
-
Martin Kutschker uploaded patch set 19 01/09/21, 21:18
-
TYPO3com voted on patch set 19 V +1 01/09/21, 21:30 Completed build in 11m 19s on Sat, 9 Jan, 09:30 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8782
-
Martin Kutschker uploaded patch set 20 01/16/21, 14:38
-
TYPO3com voted on patch set 20 V +1 01/16/21, 14:47 Completed build in 09m 27s on Sat, 16 Jan, 02:47 PM Test Summary: 32579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8881
-
Benni Mack uploaded patch set 21 01/17/21, 11:30
-
TYPO3com voted on patch set 21 V +1 01/17/21, 11:39 Completed build in 09m 25s on Sun, 17 Jan, 11:39 AM Test Summary: 32589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8895
-
Michael Telgkamp commented on patch set 21 V -1 01/17/21, 12:54
I will provide a patch for my suggestions.ModuleMenu.ts:322I do not see why we go to the previous item of the parent here. We are not 100% in the menu navigation pattern here, as we do not collapse submenus of all other items directy, so this should more behave like a treeview here I think. If I am inside the "Web" Group - e.g. on "List" module and press left, I do not expect to focus the "Dashboard" - or if Dashboard is disabled the "System" group. I think it should only focus the parent item.ModuleMenu.ts:323UnresolvedAccording to the specification of vertical menus the left arrow should open the menu and select the last item in the menu. > Opens submenu and moves focus to last item in the submenu. -
Michael Telgkamp uploaded patch set 22 01/17/21, 12:55
-
Michael Telgkamp voted on patch set 22 V +1 CR +1 01/17/21, 12:56
-
TYPO3com voted on patch set 22 V +1 01/17/21, 13:06 Completed build in 11m 04s on Sun, 17 Jan, 01:06 PM Test Summary: 32589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8897
-
Michael Telgkamp commented on patch set 22 V -1 CR 0 01/17/21, 13:11
Broke the explained behaviour, will do another patch.ModuleMenu.ts:322ReplyThis breakt the description, I will revert my changes done here. -
Michael Telgkamp uploaded patch set 23 01/17/21, 13:11
-
TYPO3com voted on patch set 23 V +1 01/17/21, 13:24 Completed build in 11m 46s on Sun, 17 Jan, 01:24 PM Test Summary: 32589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8898
-
Michael Telgkamp commented on patch set 23 V +1 CR +1 01/17/21, 13:32
Fine from my side, now. Thank you for adding this functionality to the module menu! -
Guido Schmechel commented on patch set 23 01/17/21, 16:38
I also did a little wild testing. It looks fine so far, except for the search at the top right in the backend. Enter in the search does nothing. I can't get into the search with Tab either. (Chrome) How does that look for you? -
Oli Bartsch uploaded patch set 24 01/19/21, 21:09
-
Oli Bartsch commented on patch set 24 01/19/21, 21:09
Just resolved the merge conflicts. -
TYPO3com voted on patch set 24 V +1 01/19/21, 21:21 Completed build in 11m 39s on Tue, 19 Jan, 09:21 PM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8925
-
Michael Telgkamp commented on patch set 24 V +1 CR +1 01/19/21, 22:58
Reply
Thank you for the feedback. From my point of view the global search is unrelated to the module bar. There is another issue it does not work using the keyboard: #92695. -
Guido Schmechel commented on patch set 24 V +1 01/20/21, 08:56
Reply
Ah all right. Then we'll do that separately :-) -
Richard Haeser commented on patch set 24 01/20/21, 14:52
is it correct that when I go to a submodule and use the left arrow on the first item of the submenu, I go to the previous main item? A little example: When I click on the right arrow on Admin Tools, I go to Maintenance. When I click on the left arrow after that, I go back to File. I would expect to go back to Admin Tools. Is this on purpose? -
Michael Telgkamp commented on patch set 24 01/20/21, 15:37
Reply
In the description it says it focuses the predecessor of the parent. Parent in your example is Admin Tools and the predecessor of it is File. So for me it behaves as documented. -
Richard Haeser voted on patch set 24 V +2 CR +2 01/20/21, 16:11
-
Richard Haeser merged patch set 25 01/20/21, 16:11
-
Oli Bartsch commented on patch set 25 03/16/21, 23:18
Seems like this introduced a bug, see: https://forge.typo3.org/issues/93757