66284[BUGFIX] Do not HTML encode attributes in Script and Asset VH
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Wouter Wolters +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php2+29 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php+30 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Asset/CssViewHelperTest.phpnew+85 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Asset/ScriptViewHelperTest.php+30 −12
Review log 1828
Show 23 earlier messages
-
Helmut Hummel uploaded patch set 1 10/26/20, 12:27
-
Helmut Hummel rebased onto patch set 2 10/26/20, 12:27
-
TYPO3com voted on patch set 1 V -1 10/26/20, 12:44 Completed build in 17m 28s on Mon, 26 Oct, 12:44 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6887
-
TYPO3com voted on patch set 2 V -1 10/26/20, 12:48 Completed build in 19m 18s on Mon, 26 Oct, 12:48 PM Test Summary: 1 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6888
-
Helmut Hummel uploaded patch set 3 10/26/20, 12:51
-
TYPO3com voted on patch set 3 V -1 10/26/20, 13:02 Completed build in 11m 30s on Mon, 26 Oct, 01:02 PM Test Summary: 30 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6889
-
Helmut Hummel uploaded patch set 4 10/26/20, 13:17
-
TYPO3com voted on patch set 4 V +1 10/26/20, 13:29 Completed build in 11m 44s on Mon, 26 Oct, 01:29 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6891
-
Helmut Hummel uploaded patch set 5 10/26/20, 14:47
-
TYPO3com voted on patch set 5 V -1 10/26/20, 14:48 Completed build in 21s on Mon, 26 Oct, 02:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6893
-
Helmut Hummel uploaded patch set 6 10/07/21, 12:17
-
Christian Kuhn commented on patch set 6 10/07/21, 12:19
-
core-ci voted on patch set 6 V -1 10/07/21, 12:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17736
-
Helmut Hummel uploaded patch set 7 10/07/21, 12:58
-
core-ci voted on patch set 7 V -1 10/07/21, 13:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17738
-
Helmut Hummel uploaded patch set 8 10/07/21, 13:24
-
core-ci voted on patch set 8 V +1 10/07/21, 13:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17741
-
Helmut Hummel commented on patch set 8 10/15/21, 13:01
CssViewHelperTest.php:24ReplyYeah, right. Was rebasing this old change and there are still things to be fixed. -
Georg Ringer commented on patch set 8 10/15/21, 18:20
CssViewHelper.php:49I guess this should be CSS -
Helmut Hummel uploaded patch set 9 10/16/21, 13:36
-
Helmut Hummel commented on patch set 8 10/16/21, 13:36
CssViewHelper.php:49ReplyAck -
core-ci voted on patch set 9 V -1 10/16/21, 13:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18224
-
Helmut Hummel uploaded patch set 10 10/16/21, 21:51
-
core-ci voted on patch set 10 V +1 10/16/21, 22:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18232
-
Georg Ringer voted on patch set 10 V +1 CR +1 10/19/21, 18:40
-
Wouter Wolters voted on patch set 10 CR +1 10/19/21, 20:55
-
Benni Mack voted on patch set 10 V +2 CR +2 11/05/21, 11:31
-
Benni Mack merged patch set 11 11/05/21, 11:31
CssViewHelperTest.php:24