Review 10.4 Merged

66294[BUGFIX] Prevent double escaping for src attribute in ScriptViewHelper

Daniel Goerz CR +2 V +2 Normal +126 −1 updated 10/25/20, 16:36

Commit message

This patch prevents double escaping of the src attribute by unescaping
the value before handover to the AssetCollector->addJavaScript() function.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Daniel Goerz commented on patch set 1 10/25/20, 16:20

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/25/20, 16:32 Completed build in 12m 02s on Sun, 25 Oct, 04:32 PM Test Summary: 74958 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-684

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 10/25/20, 16:36

  4. Daniel Goerz merged patch set 2 10/25/20, 16:36