Review main Merged

66314[BUGFIX] Do not re-set PreviewAspect when initializing TSFE

Benni Mack CR +2 V +2 Easy +0 −3 updated 10/27/20, 16:35

Commit message

When the Admin Panel is activated, TSFE should not
override the frontendpreview aspect by default, as
the preview settings will never work otherwise.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 710

  1. Benni Mack uploaded patch set 1 10/27/20, 13:33

  2. TYPO3com voted on patch set 1 V -1 10/27/20, 13:45 Completed build in 12m 04s on Tue, 27 Oct, 01:45 PM Test Summary: 1 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6907

  3. Benni Mack uploaded patch set 2 10/27/20, 14:03

  4. TYPO3com voted on patch set 2 V -1 10/27/20, 14:03 Completed build in 26s on Tue, 27 Oct, 02:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6908

  5. Benni Mack uploaded patch set 3 10/27/20, 14:04

  6. Susi Moog voted on patch set 3 V +1 CR +1 10/27/20, 14:10

  7. TYPO3com voted on patch set 3 V +1 10/27/20, 14:17 Completed build in 12m 24s on Tue, 27 Oct, 02:16 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6909

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 10/27/20, 15:44

  9. Benni Mack voted on patch set 3 V +2 CR +2 10/27/20, 16:35

  10. Benni Mack merged patch set 4 10/27/20, 16:35