66315[TASK] Always use list of pids as array in linkvalidator
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Goerz +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+1 −1
- typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php+2 −2
- typo3/sysext/linkvalidator/Classes/Repository/PagesRepository.php+4 −0
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php3+4 −4
- typo3/sysext/linkvalidator/Tests/Functional/Repository/BrokenLinkRepositoryTest.php+4 −4
- typo3/sysext/linkvalidator/Tests/Functional/LinkAnalyzerTest.php+19 −19
Review log 1726
Show 1 earlier messages
-
Sybille Peters uploaded patch set 1 10/27/20, 14:41
-
TYPO3com voted on patch set 1 V +1 10/27/20, 14:53 Completed build in 11m 52s on Tue, 27 Oct, 02:53 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6910
-
Sybille Peters updated the commit message in patch set 2 10/27/20, 14:54
-
TYPO3com voted on patch set 2 V +1 10/27/20, 15:11 Completed build in 15m 12s on Tue, 27 Oct, 03:11 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6912
-
Sybille Peters wrote 11/03/20, 14:59
Topic set to Linkvalidator -
Sybille Peters commented on patch set 2 CR -1 11/20/20, 15:14
I will resolve merge conflict -
Sybille Peters uploaded patch set 3 11/20/20, 15:16
-
Sybille Peters wrote 11/20/20, 15:16
Description set to "Resolved merge conflict" -
TYPO3com voted on patch set 3 V +1 11/20/20, 15:27 Completed build in 10m 41s on Fri, 20 Nov, 03:27 PM Test Summary: 32389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7472
-
Sybille Peters uploaded patch set 4 12/13/20, 10:57
-
TYPO3com voted on patch set 4 V -1 12/13/20, 11:07 Completed build in 10m 06s on Sun, 13 Dec, 11:07 AM Test Summary: 30277 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8131
-
TYPO3com voted on patch set 4 V +1 12/14/20, 09:32 Completed build in 09m 26s on Mon, 14 Dec, 09:32 AM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8143
-
Benni Mack uploaded patch set 5 03/22/21, 18:53
-
Benni Mack uploaded patch set 6 03/22/21, 18:54
-
Benni Mack voted on patch set 6 CR +1 03/22/21, 18:55
-
TYPO3com voted on patch set 5 V +1 03/22/21, 19:00 Completed build in 06m 34s on Mon, 22 Mar, 07:00 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10294
-
TYPO3com voted on patch set 6 V +1 03/22/21, 19:01 Completed build in 06m 35s on Mon, 22 Mar, 07:01 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10295
-
Daniel Goerz voted on patch set 6 V +1 CR +1 03/22/21, 19:04
-
core-ci voted on patch set 5 V +1 03/22/21, 19:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1767
-
core-ci voted on patch set 6 V +1 03/22/21, 19:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1768
-
Benni Mack voted on patch set 6 V +2 CR +2 03/22/21, 19:38
-
Benni Mack merged patch set 7 03/22/21, 19:38
-
Susi Moog commented on patch set 7 03/23/21, 17:54
LinkAnalyzer.php:104This introduced a bug because LinkAnalyzerResult calls it like this: ->init($searchFields, implode(',', $pageIds), $modTSconfig); -
Daniel Goerz commented on patch set 7 03/23/21, 18:09
LinkAnalyzer.php:104Replywoopsie. I'll fix that in a minute. I wonder why phpstan did not complain about this. Looks like an obvious type missmatch. -
Daniel Goerz commented on patch set 7 03/23/21, 18:16
LinkAnalyzer.php:104Reply Unresolved -
Sybille Peters commented on patch set 7 05/04/21, 09:56
I would like to suggest making this an optional parameter. This way, if no pids are given, all startpages with a configured site could be used. (Sorry, just saw that this was already merged.)