Review main Merged

66316[TASK] Use Symfony Routing for Backend Routing

Benni Mack CR +2 V +2 Hard +142 −168 updated 11/01/20, 18:24

Commit message

This is a pre-cursor for enhancing Backend Routing in general.

This change implements Symfony Routing for Backend
Routes (currently based on the "route" GET/POST argument)
internally to make use of their compiled routes later-on.

This was previously done in a simplified version where only
the path was checked against, and most Symfony features
were not in use, which we still don't use yet, but more can now
be added.

When Backend Routing was added in TYPO3 v7, the API
was heavily influenced by Symfony but we did not have
a lot of experience yet, which we benefitted in TYPO3 v9+
for Frontend Routing.

With this experience (and with PSR-15) we can gradually
move to a more streamlined and faster API.

The proposed solution still works as expected with &route
GET parameters, but opens up the door for flexible Route arguments.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1324

  1. Benni Mack uploaded patch set 1 10/27/20, 14:53

  2. TYPO3com voted on patch set 1 V -1 10/27/20, 15:05 Completed build in 11m 50s on Tue, 27 Oct, 03:05 PM Test Summary: 147 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6911

  3. Benni Mack uploaded patch set 2 10/27/20, 21:40

  4. Benni Mack uploaded patch set 3 10/27/20, 21:47

  5. Benni Mack updated the commit message in patch set 4 10/27/20, 21:49

  6. Benni Mack updated the commit message in patch set 5 10/27/20, 21:52

  7. TYPO3com voted on patch set 2 V -1 10/27/20, 22:02 Completed build in 21m 50s on Tue, 27 Oct, 10:02 PM Test Summary: 93 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6945

  8. TYPO3com voted on patch set 3 V -1 10/27/20, 22:11 Completed build in 19m 07s on Tue, 27 Oct, 10:11 PM Test Summary: 12 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6946

  9. TYPO3com voted on patch set 4 V -1 10/27/20, 22:17 Completed build in 25m 09s on Tue, 27 Oct, 10:17 PM Test Summary: 12 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6947

  10. TYPO3com voted on patch set 5 V -1 10/27/20, 22:22 Completed build in 30m 14s on Tue, 27 Oct, 10:22 PM Test Summary: 12 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6948

  11. Benni Mack uploaded patch set 6 10/28/20, 07:25

  12. TYPO3com voted on patch set 6 V -1 10/28/20, 07:37 Completed build in 11m 55s on Wed, 28 Oct, 07:37 AM Test Summary: 3 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6953

  13. TYPO3com commented on patch set 6 10/28/20, 10:54 Completed build in 3h 39m 52s on Wed, 28 Oct, 10:53 AM Test Summary: 3 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6953

  14. Benni Mack rebased onto patch set 7 10/28/20, 10:54

  15. TYPO3com voted on patch set 7 V +1 10/28/20, 11:05 Completed build in 11m 09s on Wed, 28 Oct, 11:05 AM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6965

  16. Oli Bartsch uploaded patch set 8 10/30/20, 08:34

  17. Oli Bartsch voted on patch set 8 V +1 CR +1 10/30/20, 08:35

  18. TYPO3com voted on patch set 8 V -1 10/30/20, 08:36 Completed build in 23s on Fri, 30 Oct, 08:36 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7024

  19. TYPO3com commented on patch set 8 10/30/20, 08:41 Completed build in 21s on Fri, 30 Oct, 08:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7025

  20. Oli Bartsch rebased onto patch set 9 10/30/20, 08:48

  21. TYPO3com voted on patch set 9 V +1 10/30/20, 09:05 Completed build in 15m 25s on Fri, 30 Oct, 09:05 AM Test Summary: 73554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7026

  22. Oli Bartsch voted on patch set 9 V +1 CR +1 10/30/20, 09:06

  23. Georg Ringer voted on patch set 9 V +2 CR +2 11/01/20, 18:24

  24. Georg Ringer merged patch set 10 11/01/20, 18:24