66318[TASK] Add content type info when creating content
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1113
-
Michael Telgkamp uploaded patch set 1 10/27/20, 16:13
-
Michael Telgkamp wrote 10/27/20, 16:13
Topic set to a11y -
TYPO3com voted on patch set 1 V -1 10/27/20, 16:27 Completed build in 13m 35s on Tue, 27 Oct, 04:27 PM Test Summary: 1 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6916
-
Michael Telgkamp commented on patch set 1 V -1 CR -1 10/27/20, 16:59
The checkIfUpdatedFileMetadataIsUpdatedInContent test needs to be adjusted for this to work fine. -
Martin Kutschker uploaded patch set 2 12/06/20, 11:06
-
TYPO3com voted on patch set 2 V +1 12/06/20, 11:15 Completed build in 08m 46s on Sun, 6 Dec, 11:15 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7847
-
Michael Telgkamp voted on patch set 2 V +1 CR +1 12/06/20, 13:38
-
Riccardo De Contardi voted on patch set 2 V +1 12/06/20, 15:00
-
Benjamin Franzke commented on patch set 2 CR -1 12/06/20, 20:07
Hm.. I'm not sure about this one. We get two "schemes" with this change: 1. new: Create new Page Content "[Content-Element-Type]" on page "Page Name" 2. a) edit: Edit Page Content "[Header]" on page "Page Name" 2. b) edit (without header): Edit Page Content on page "Page Name" Now 1 and 2a kinda conflict by changes the meaning of the first segment in the header statement. 2b then kinda asks for "content type" inclusing. Maybe we should rather write Create "[Content-Element-Type]" on page "Page Name"OuterWrapContainer.php:83UnresolvedThe page title is outputed via <f:format.raw> in EXT:backend/Resources/Private/Templates/OuterWrapContainer.html This therefore needs htmlspecialchars(), also see lines below. (Yes that $tableTitle wasn't htmlspecialchared` before isn't good either, but rendering custom content type labels without escaping will make it worse) -
Martin Kutschker commented on patch set 2 12/07/20, 15:59
Reply
I also had the feeling that the Page Content before the type in 1) is not really needed. Sidenote: the mixed first cases of the words in the header looks odd. Either all lower case or proper English title case (nearly everything upper case) -
Martin Kutschker commented on patch set 2 CR -1 12/13/20, 16:16
Without a new translation label this path may lead to broken text in some languages.OuterWrapContainer.php:88UnresolvedA hardcoded text sequence breaks the translation system. A translation may need a different position for the added $recordTypeLabel with the full label or it does not use Latin quotes. -
Benni Mack commented on patch set 2 11/04/21, 13:44
how to continue here? this patch is now around for 11 months without activity. -
Benni Mack abandoned the change 11/26/21, 22:48
abandoned due to lack of activity, can be picked up later again